Deeper chunking of node stats response#95060
Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom Apr 6, 2023
Merged
Deeper chunking of node stats response#95060elasticsearchmachine merged 3 commits intoelastic:mainfrom
elasticsearchmachine merged 3 commits intoelastic:mainfrom
Conversation
Pushes the chunking of `GET _nodes/stats` down to avoid creating unboundedly large chunks. With this commit we yield one chunk per shard (if `?level=shards`) or index (if `?level=indices`) and per HTTP client and per transport action. Closes elastic#93985
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
original-brownbear
approved these changes
Apr 5, 2023
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, did my best to make sure the format didn't change anywhere but looks fine 🤞 :)
Member
Author
me too :) |
Member
Author
|
@elasticmachine please run elasticsearch-ci/part-1 |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 6, 2023
Ingest stats are O(pipelines*processors) too, and that could be quite a large amount of data in some cases. Relates elastic#95060
DaveCTurner
added a commit
that referenced
this pull request
Apr 6, 2023
Ingest stats are O(pipelines*processors) too, and that could be quite a large amount of data in some cases. Relates #95060
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushes the chunking of
GET _nodes/statsdown to avoid creating unboundedly large chunks. With this commit we yield one chunk per shard (if?level=shards) or index (if?level=indices) and per HTTP client and per transport action.Closes #93985