Skip to content

Add tests checking final_pipelines in YAML tests#94388

Merged
HiDAl merged 2 commits intoelastic:mainfrom
HiDAl:add-yaml-test-final-pipeline
Mar 8, 2023
Merged

Add tests checking final_pipelines in YAML tests#94388
HiDAl merged 2 commits intoelastic:mainfrom
HiDAl:add-yaml-test-final-pipeline

Conversation

@HiDAl
Copy link
Copy Markdown

@HiDAl HiDAl commented Mar 8, 2023

Relates to #83653

Add a commented test that ensures that final_pipeline is executed only once. Since we're touching on that part of the code, with @joegallo we want to be sure that we have some safety net here.

Replay of #94281 which was reverted in #94372

Pablo Alcantar Morales added 2 commits March 8, 2023 11:51
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.8.0 labels Mar 8, 2023
@HiDAl HiDAl added >test Issues or PRs that are addressing/adding tests :Distributed/Ingest Node Execution or management of Ingest Pipelines Team:Data Management (obsolete) DO NOT USE. This team no longer exists. labels Mar 8, 2023
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Mar 8, 2023
Copy link
Copy Markdown
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@HiDAl HiDAl merged commit 20588b1 into elastic:main Mar 8, 2023
@HiDAl HiDAl deleted the add-yaml-test-final-pipeline branch March 8, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Ingest Node Execution or management of Ingest Pipelines Team:Data Management (obsolete) DO NOT USE. This team no longer exists. >test Issues or PRs that are addressing/adding tests v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants