Add tests checking final_pipelines in YAML tests#94281
Merged
HiDAl merged 3 commits intoelastic:mainfrom Mar 7, 2023
Merged
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
approved these changes
Mar 6, 2023
Contributor
joegallo
left a comment
There was a problem hiding this comment.
Added a commit and now it LGTM. The crucial thing for me is that we get a test of the current behavior (bugs and all), so that if the behavior changes we realize that.
HiDAl
pushed a commit
to HiDAl/elasticsearch
that referenced
this pull request
Mar 7, 2023
…)" This reverts commit a9b35ba.
HiDAl
pushed a commit
that referenced
this pull request
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #83653
Add a commented test that ensures that
final_pipelineis executed only once. Since we're touching on that part of the code, with @joegallo we want to be sure that we have some safety net here.