Skip to content

Fixing HistoryIntegrationTests to wait for watcher history#94286

Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom
masseyke:HistoryIntegrationTests-fix
Mar 2, 2023
Merged

Fixing HistoryIntegrationTests to wait for watcher history#94286
elasticsearchmachine merged 1 commit intoelastic:mainfrom
masseyke:HistoryIntegrationTests-fix

Conversation

@masseyke
Copy link
Copy Markdown
Member

@masseyke masseyke commented Mar 2, 2023

In #94133 we started loading watcher history asynchronously. I missed updating a test in HistoryIntegrationTests to wait for the history to be indexed. This fixes that.

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Distributed/Watcher v8.8.0 auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Mar 2, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Mar 2, 2023
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine merged commit 8132c96 into elastic:main Mar 2, 2023
@masseyke masseyke deleted the HistoryIntegrationTests-fix branch March 2, 2023 18:17
ChrisHegarty pushed a commit that referenced this pull request Aug 9, 2023
In #94133 we started
loading watcher history asynchronously. I missed updating a test in
HistoryIntegrationTests to wait for the history to be indexed. This
fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Watcher Team:Data Management (obsolete) DO NOT USE. This team no longer exists. >test Issues or PRs that are addressing/adding tests v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants