Deprecate _knn_search in the REST spec#94103
Merged
javanna merged 2 commits intoelastic:mainfrom Mar 2, 2023
Merged
Conversation
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
benwtrent
approved these changes
Mar 2, 2023
This was referenced Mar 2, 2023
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
Collaborator
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
ChrisHegarty
pushed a commit
that referenced
this pull request
Aug 9, 2023
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec.
Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the section.