Introduce RefCountingListener#isFailing#93101
Closed
DaveCTurner wants to merge 1 commit intoelastic:mainfrom
Closed
Introduce RefCountingListener#isFailing#93101DaveCTurner wants to merge 1 commit intoelastic:mainfrom
DaveCTurner wants to merge 1 commit intoelastic:mainfrom
Conversation
Sometimes it's useful to know whether any of the other acquired listeners have failed. For instance, it may be preferable to avoid doing certain async tasks if we already know that the overall operation will fail due to the failure of an an earlier task. This commit exposes this information on `RefCountingListener`.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
Actually I don't have a use-case for this yet, marking it as WIP for now. |
Member
Author
|
We introduced this in #94507. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 28, 2023
Added in elastic#94507 but without the comment from elastic#93101, which this commit fixes.
DaveCTurner
added a commit
that referenced
this pull request
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful to know whether any of the other acquired listeners have failed. For instance, it may be preferable to avoid doing certain async tasks if we already know that the overall operation will fail due to the failure of an an earlier task. This commit exposes this information on
RefCountingListener.