[Stable plugin api] Drop api suffix in package names#92905
Merged
pgomulka merged 5 commits intoelastic:mainfrom Jan 14, 2023
Merged
[Stable plugin api] Drop api suffix in package names#92905pgomulka merged 5 commits intoelastic:mainfrom
pgomulka merged 5 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
refactoring that drops the api suffix from package name This will have to be followed up by a plugins/examples fix in imports Also set an artifact group name corresponding to the dominating package in the plugin-api and plugin-analysis-api
4543a8c to
3ec11ed
Compare
This was referenced Jan 13, 2023
rjernst
reviewed
Jan 13, 2023
| apply plugin: 'elasticsearch.publish' | ||
| apply plugin: 'elasticsearch.build' | ||
|
|
||
| group = "org.elasticsearch.plugin.analysis" |
Member
There was a problem hiding this comment.
I think it would cleaner to have this directly under org.elasticsearch.plugin. There is no need for a unique group per artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring that drops the api suffix from package name
This will have to be followed up by a plugins/examples fix in imports
Also set an artifact group name to
org.elasticsearch.pluginin the plugin-api and plugin-analysis-api