Add util method to build a Geometry from an H3 cell#92883
Merged
iverase merged 2 commits intoelastic:mainfrom Jan 16, 2023
Merged
Add util method to build a Geometry from an H3 cell#92883iverase merged 2 commits intoelastic:mainfrom
iverase merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
craigtaverner
approved these changes
Jan 16, 2023
Contributor
craigtaverner
left a comment
There was a problem hiding this comment.
Generally I liked this, but did have a few questions.
x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/common/H3CartesianUtil.java
Show resolved
Hide resolved
x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/common/H3CartesianUtil.java
Show resolved
Hide resolved
x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/common/H3CartesianUtil.java
Show resolved
Hide resolved
x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/common/H3CartesianUtil.java
Show resolved
Hide resolved
...lugin/spatial/src/test/java/org/elasticsearch/xpack/spatial/common/H3CartesianUtilTests.java
Outdated
Show resolved
Hide resolved
nreese
added a commit
to elastic/kibana
that referenced
this pull request
Feb 9, 2023
…api_integration/apis/maps/get_grid_tile.js (#150768) Fixes #149068 Order of the vertices changed as side effect of elastic/elasticsearch#92883. PR updates expects clause for new order
kibanamachine
pushed a commit
to elastic/kibana
that referenced
this pull request
Feb 9, 2023
…api_integration/apis/maps/get_grid_tile.js (#150768) Fixes #149068 Order of the vertices changed as side effect of elastic/elasticsearch#92883. PR updates expects clause for new order (cherry picked from commit d6a4ebf)
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
Feb 9, 2023
…/test/api_integration/apis/maps/get_grid_tile.js (#150768) (#150794) # Backport This will backport the following commits from `main` to `8.7`: - [fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (#150768)](#150768) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-02-09T21:35:28Z","message":"fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (#150768)\n\nFixes https://github.com/elastic/kibana/issues/149068\r\n\r\nOrder of the vertices changed as side effect of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates expects\r\nclause for new order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","auto-backport","Feature:Maps","v8.7.0","v8.8.0"],"number":150768,"url":"https://github.com/elastic/kibana/pull/150768","mergeCommit":{"message":"fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (#150768)\n\nFixes https://github.com/elastic/kibana/issues/149068\r\n\r\nOrder of the vertices changed as side effect of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates expects\r\nclause for new order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150768","number":150768,"mergeCommit":{"message":"fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (#150768)\n\nFixes https://github.com/elastic/kibana/issues/149068\r\n\r\nOrder of the vertices changed as side effect of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates expects\r\nclause for new order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few places where we need to build a Geometry from an H3 cell, therefore lets add a method on H3cartesianUtil that does that. This allows to make sure we build valid geometries that can be indexed. Therefore in this Pr we are