Fix ReopenWhileClosingIT Deadlocks#92662
Merged
original-brownbear merged 1 commit intoelastic:mainfrom Jan 4, 2023
original-brownbear:fix-blocking-management-pool
Merged
Fix ReopenWhileClosingIT Deadlocks#92662original-brownbear merged 1 commit intoelastic:mainfrom original-brownbear:fix-blocking-management-pool
original-brownbear merged 1 commit intoelastic:mainfrom
original-brownbear:fix-blocking-management-pool
Conversation
Instead of blocking either a transport or management thread here (the latter will lead to a dead-lock if there's only a single management thread available, we should just queue up those sends and run them async via listener). This test is currently only working on `main` because of #90193, this makes it work with a single management thread as well so it works on 7.x again. closes #92629
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
Thanks Tanguy! |
This was referenced Jan 4, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 4, 2023
Instead of blocking either a transport or management thread here (the latter will lead to a dead-lock if there's only a single management thread available, we should just queue up those sends and run them async via listener). This test is currently only working on `main` because of #90193, this makes it work with a single management thread as well so it works on 7.x again. closes #92629
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 4, 2023
Instead of blocking either a transport or management thread here (the latter will lead to a dead-lock if there's only a single management thread available, we should just queue up those sends and run them async via listener). This test is currently only working on `main` because of #90193, this makes it work with a single management thread as well so it works on 7.x again. closes #92629
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of blocking either a transport or management thread here (the latter will lead to a dead-lock if there's only a single management thread available, we should just queue up those sends and run them async via listener).
This test is currently only working on
mainbecause of #90193, this makes it work with a single management thread as well so it works on 7.x again.closes #92629