[TEST] Fix FileSettingsRoleMappingsStartupIT#92653
Merged
grcevski merged 1 commit intoelastic:mainfrom Jan 4, 2023
Merged
Conversation
Disable mock lucene file systems that throw an error where IOException is expected.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Member
|
Sounds sensible. Is there an alternative mock file system we could use instead, or some way to modify the lucene one to throw the right sort of exception? |
Contributor
Author
I looked at various options in |
Member
|
Ideally we would have a mock file system that acted the same as the real file system, so we don't pollute the real FS with files. But if that doesn't exist, then using the real FS is ok. |
thecoop
approved these changes
Jan 4, 2023
Contributor
Author
|
Thanks Simon! |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
grcevski
added a commit
that referenced
this pull request
Jan 4, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 11, 2024
Several file-settings ITs fail (rarely) with exceptions like: ``` java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempFile-001.tmp -> C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempDir-002\config\operator\settings.json | at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89) | -- | -- | | at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) | | | at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317) | | | at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at java.nio.file.Files.move(Files.java:1430) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.writeJSONFile(SnaphotsAndFileSettingsIT.java:86) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.testRestoreWithPersistedFileSettings(SnaphotsAndFileSettingsIT.java:321) ``` This happens in Windows file systems, due to a race condition where the file settings service is reading the settings file concurrently with the test trying to modify it (a no-go in Windows). It turns out we have already addressed this with a retry for one test suite (#91863), plus addressed a related issue around mock windows file-systems misbehaving (#92653). This PR extends the above fixes to all file-settings related ITs.
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 13, 2024
…6392) Several file-settings ITs fail (rarely) with exceptions like: ``` java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempFile-001.tmp -> C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempDir-002\config\operator\settings.json | at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89) | -- | -- | | at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) | | | at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317) | | | at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at java.nio.file.Files.move(Files.java:1430) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.writeJSONFile(SnaphotsAndFileSettingsIT.java:86) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.testRestoreWithPersistedFileSettings(SnaphotsAndFileSettingsIT.java:321) ``` This happens in Windows file systems, due to a race condition where the file settings service is reading the settings file concurrently with the test trying to modify it (a no-go in Windows). It turns out we have already addressed this with a retry for one test suite (elastic#91863), plus addressed a related issue around mock windows file-systems misbehaving (elastic#92653). This PR extends the above fixes to all file-settings related ITs. (cherry picked from commit 91559da)
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 13, 2024
…6392) Several file-settings ITs fail (rarely) with exceptions like: ``` java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempFile-001.tmp -> C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempDir-002\config\operator\settings.json | at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89) | -- | -- | | at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) | | | at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317) | | | at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at java.nio.file.Files.move(Files.java:1430) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.writeJSONFile(SnaphotsAndFileSettingsIT.java:86) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.testRestoreWithPersistedFileSettings(SnaphotsAndFileSettingsIT.java:321) ``` This happens in Windows file systems, due to a race condition where the file settings service is reading the settings file concurrently with the test trying to modify it (a no-go in Windows). It turns out we have already addressed this with a retry for one test suite (elastic#91863), plus addressed a related issue around mock windows file-systems misbehaving (elastic#92653). This PR extends the above fixes to all file-settings related ITs. (cherry picked from commit 91559da)
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
Several file-settings ITs fail (rarely) with exceptions like: ``` java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempFile-001.tmp -> C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempDir-002\config\operator\settings.json | at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89) | -- | -- | | at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) | | | at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317) | | | at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at java.nio.file.Files.move(Files.java:1430) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.writeJSONFile(SnaphotsAndFileSettingsIT.java:86) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.testRestoreWithPersistedFileSettings(SnaphotsAndFileSettingsIT.java:321) ``` This happens in Windows file systems, due to a race condition where the file settings service is reading the settings file concurrently with the test trying to modify it (a no-go in Windows). It turns out we have already addressed this with a retry for one test suite (#91863), plus addressed a related issue around mock windows file-systems misbehaving (#92653). This PR extends the above fixes to all file-settings related ITs.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 13, 2024
…116709) Several file-settings ITs fail (rarely) with exceptions like: ``` java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempFile-001.tmp -> C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempDir-002\config\operator\settings.json | at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89) | -- | -- | | at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) | | | at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317) | | | at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at java.nio.file.Files.move(Files.java:1430) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.writeJSONFile(SnaphotsAndFileSettingsIT.java:86) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.testRestoreWithPersistedFileSettings(SnaphotsAndFileSettingsIT.java:321) ``` This happens in Windows file systems, due to a race condition where the file settings service is reading the settings file concurrently with the test trying to modify it (a no-go in Windows). It turns out we have already addressed this with a retry for one test suite (#91863), plus addressed a related issue around mock windows file-systems misbehaving (#92653). This PR extends the above fixes to all file-settings related ITs. (cherry picked from commit 91559da)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 14, 2024
…116710) Several file-settings ITs fail (rarely) with exceptions like: ``` java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempFile-001.tmp -> C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempDir-002\config\operator\settings.json | at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89) | -- | -- | | at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) | | | at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317) | | | at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at java.nio.file.Files.move(Files.java:1430) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.writeJSONFile(SnaphotsAndFileSettingsIT.java:86) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.testRestoreWithPersistedFileSettings(SnaphotsAndFileSettingsIT.java:321) ``` This happens in Windows file systems, due to a race condition where the file settings service is reading the settings file concurrently with the test trying to modify it (a no-go in Windows). It turns out we have already addressed this with a retry for one test suite (#91863), plus addressed a related issue around mock windows file-systems misbehaving (#92653). This PR extends the above fixes to all file-settings related ITs. (cherry picked from commit 91559da) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 14, 2024
…6392) Several file-settings ITs fail (rarely) with exceptions like: ``` java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempFile-001.tmp -> C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempDir-002\config\operator\settings.json | at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89) | -- | -- | | at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) | | | at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317) | | | at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at java.nio.file.Files.move(Files.java:1430) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.writeJSONFile(SnaphotsAndFileSettingsIT.java:86) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.testRestoreWithPersistedFileSettings(SnaphotsAndFileSettingsIT.java:321) ``` This happens in Windows file systems, due to a race condition where the file settings service is reading the settings file concurrently with the test trying to modify it (a no-go in Windows). It turns out we have already addressed this with a retry for one test suite (elastic#91863), plus addressed a related issue around mock windows file-systems misbehaving (elastic#92653). This PR extends the above fixes to all file-settings related ITs.
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…6392) Several file-settings ITs fail (rarely) with exceptions like: ``` java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempFile-001.tmp -> C:\Users\jenkins\workspace\platform-support\14\server\build\testrun\internalClusterTest\temp\org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT_5733F2A737542BE-001\tempDir-002\config\operator\settings.json | at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89) | -- | -- | | at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) | | | at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317) | | | at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.move(FilterFileSystemProvider.java:144) | | | at java.nio.file.Files.move(Files.java:1430) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.writeJSONFile(SnaphotsAndFileSettingsIT.java:86) | | | at org.elasticsearch.reservedstate.service.SnaphotsAndFileSettingsIT.testRestoreWithPersistedFileSettings(SnaphotsAndFileSettingsIT.java:321) ``` This happens in Windows file systems, due to a race condition where the file settings service is reading the settings file concurrently with the test trying to modify it (a no-go in Windows). It turns out we have already addressed this with a retry for one test suite (elastic#91863), plus addressed a related issue around mock windows file-systems misbehaving (elastic#92653). This PR extends the above fixes to all file-settings related ITs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable mock lucene file systems that throw an error where IOException is expected.
FileSettingsService uses the Java WatchService to detect when the file settings have been modified. While processing the current file settings, the file can get replaced on the file system which might cause an IOException at various places when we are in the process of reading the file.
Throwing an IOException because of an overwritten file is harmless. We'll simply abandon the current file settings processing and we'll process the next event from the watcher service.
However, the mock file systems that we use by default from lucene turn this IOException into a j.l.AssertionError, which isn't an Exception but extends from j.l.Error. Since we only handle Exceptions in the catch block, the Error is propagated all the way to the watcher thread and effectively the file settings service thread terminates.
With this PR I'm disabling the mock file systems, we should be testing the actual file system functionality. If this PR fixes the issue, I'll apply the same fix to the other similar FileSettingsService tests.
Closes #92242