Refactor plugin scanning into lib#92437
Merged
pgomulka merged 20 commits intoelastic:mainfrom Jan 9, 2023
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
requested changes
Dec 21, 2022
Contributor
breskeby
left a comment
There was a problem hiding this comment.
some minor changes. I think only having the tests enabled again is a blocker from my perspective to merge this though
libs/plugin-scanner/build.gradle
Outdated
| */ | ||
|
|
||
| // This is only required because :server needs this at runtime. | ||
| // We'll be removing this in 8.0 so for now just publish the JAR to make dependency resolution work. |
Contributor
There was a problem hiding this comment.
is this comment actually true? I think this is outdated copied from somewhere?
Contributor
There was a problem hiding this comment.
I think we always need to publish this
Contributor
Author
There was a problem hiding this comment.
that was a copy paste. good spot
libs/plugin-scanner/build.gradle
Outdated
|
|
||
| implementation 'org.ow2.asm:asm:9.2' | ||
| implementation 'org.ow2.asm:asm-tree:9.2' | ||
| // implementation "com.fasterxml.jackson.core:jackson-core:${versions.jackson}" |
libs/plugin-scanner/build.gradle
Outdated
| tasks.named("test").configure { enabled = false } | ||
|
|
||
| // test depend on ES core... | ||
| tasks.named('forbiddenApisMain').configure { enabled = false} |
libs/plugin-scanner/build.gradle
Outdated
| // We'll be removing this in 8.0 so for now just publish the JAR to make dependency resolution work. | ||
| apply plugin: 'elasticsearch.publish' | ||
|
|
||
| tasks.named("test").configure { enabled = false } |
Contributor
There was a problem hiding this comment.
that test task should be enabled as we actually have tests in that lib project
breskeby
approved these changes
Jan 9, 2023
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 13, 2023
new stable plugins require generated named_components.json file which contains all analysis components implemented by this plugin. The generation is currently done in build-tools by elasticsearch.stable-esplugin However this makes the generation only available for plugins using gradle. Plugin developers using maven or other building tooling will not be able to use it. This commits refactors the scanning logic into libs:plugin-scanner which will allow for plugin install command to perform the scanning too. relates elastic#88980
This was referenced Jan 13, 2023
pgomulka
added a commit
that referenced
this pull request
Jan 14, 2023
new stable plugins require generated named_components.json file which contains all analysis components implemented by this plugin. The generation is currently done in build-tools by elasticsearch.stable-esplugin However this makes the generation only available for plugins using gradle. Plugin developers using maven or other building tooling will not be able to use it. This commits refactors the scanning logic into libs:plugin-scanner which will allow for plugin install command to perform the scanning too. relates #88980 backports #92437
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 20, 2023
…tic#92899)" This reverts commit 92a9cc1.
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 20, 2023
Part of elastic#92437 where Classreaders was refactored to return a List instead of Stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new stable plugins require generated named_components.json file which contains all analysis components implemented by this plugin. The generation is currently done in build-tools by elasticsearch.stable-esplugin
However this makes the generation only available for plugins using gradle. Plugin developers using maven or other building tooling will not be able to use it.
This commits refactors the scanning logic into libs:plugin-scanner which will allow for plugin install command to perform the scanning too.
relates #88980