Fix ref-counting in DisruptableMockTransport#92245
Merged
elasticsearchmachine merged 4 commits intoelastic:mainfrom Dec 12, 2022
Merged
Conversation
Today `DisruptableMockTransport` leaks refs to transport messages in various ways if the transport is rebooted. This commit adds the missing ref-count handling. Closes elastic#91837
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
approved these changes
Dec 12, 2022
Member
pxsalehi
left a comment
There was a problem hiding this comment.
LGTM. Is there a reason we don't backport to 7.17? The failure wouldn't happen on 7.17? (also some classes are moved here and on 7.17 they'd be somewhere else.)
Member
Author
|
In practice I think this only really became a problem with the introduction of |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine please run elasticsearch-ci/packaging-tests-windows-sample |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 12, 2022
Today `DisruptableMockTransport` leaks refs to transport messages in various ways if the transport is rebooted. This commit adds the missing ref-count handling. Closes elastic#91837
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2022
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 12, 2022
We simulate sending traffic along a blackholed connection with a disconnection exception that we withold until far into the future. Today this exception is delivered using the transport of the responding node, but it should be the requesting node. This commit fixes that. Not sure how this _ever_ worked, but we made things stricter in elastic#92245 and that meant this bug led to test failures. Closes elastic#92307
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 13, 2022
We simulate sending traffic along a blackholed connection with a disconnection exception that we withold until far into the future. Today this exception is delivered using the transport of the responding node, but it should be the requesting node. This commit fixes that. Not sure how this _ever_ worked, but we made things stricter in #92245 and that meant this bug led to test failures. Closes #92307
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 13, 2022
We simulate sending traffic along a blackholed connection with a disconnection exception that we withold until far into the future. Today this exception is delivered using the transport of the responding node, but it should be the requesting node. This commit fixes that. Not sure how this _ever_ worked, but we made things stricter in elastic#92245 and that meant this bug led to test failures. Closes elastic#92307
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 13, 2022
We simulate sending traffic along a blackholed connection with a disconnection exception that we withold until far into the future. Today this exception is delivered using the transport of the responding node, but it should be the requesting node. This commit fixes that. Not sure how this _ever_ worked, but we made things stricter in #92245 and that meant this bug led to test failures. Closes #92307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today
DisruptableMockTransportleaks refs to transport messages in various ways if the transport is rebooted. This commit adds the missing ref-count handling.Closes #91837