Skip to content

Fix PersistentTasksClusterServiceTests#92002

Merged
DaveCTurner merged 1 commit intoelastic:mainfrom
DaveCTurner:2022-11-29-PersistentTasksClusterServiceTests-waiting
Nov 29, 2022
Merged

Fix PersistentTasksClusterServiceTests#92002
DaveCTurner merged 1 commit intoelastic:mainfrom
DaveCTurner:2022-11-29-PersistentTasksClusterServiceTests-waiting

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

Today these tests don't wait for the assertions to run before shutting down the master service, and today if the master service shuts down then work (such as these assertions) is silently dropped. This commit ensures that the assertions have run before the test completes.

Today these tests don't wait for the assertions to run before shutting
down the master service, and today if the master service shuts down then
work (such as these assertions) is silently dropped. This commit ensures
that the assertions have run before the test completes.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. v8.7.0 labels Nov 29, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Nov 29, 2022
Copy link
Copy Markdown
Member

@pxsalehi pxsalehi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit d3fbb3e into elastic:main Nov 29, 2022
@DaveCTurner DaveCTurner deleted the 2022-11-29-PersistentTasksClusterServiceTests-waiting branch November 29, 2022 17:24
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Dec 2, 2022
* upstream/main: (209 commits)
  Remove unused methods and classes from HLRC (elastic#92030)
  Clean up on exception while chunking XContent (elastic#92024)
  Add profiling plugin (elastic#91640)
  Remove unused methods and classes from HLRC (elastic#92012)
  Remove IndexerState from HLRC (elastic#92023)
  Ensure cached time elapses in ClusterServiceIT (elastic#91986)
  Chunked encoding for RestGetIndicesAction (elastic#92016)
  Simplify shardsWithState (elastic#91991)
  [DOCS] Updates ML decider docs by mentioning CPU as scaling criterion (elastic#92018)
  Add chunking to ClusterState.Custom impls (elastic#91963)
  Speedup time_series agg by caching current tsid ordinal, parent bucket ordinal and buck ordinal (elastic#91784)
  Drop the ingest listener call count tracking (elastic#92003)
  [DOCS] fixes issue number 91889 - missing [discrete] header (elastic#91976)
  Fix PersistentTasksClusterServiceTests (elastic#92002)
  [docs] Update search-settings documentation to reflect the fact that the indices.query.bool.max_clause_count setting has been deprecated (elastic#91811)
  Clarify writability in Netty4HttpPipeliningHandler (elastic#91982)
  Load stable plugins as synthetic modules (elastic#91869)
  Handle any exception thrown while generating source for an IngestDocument (elastic#91981)
  fixing Apache HttpHost url on java-rest doc (elastic#91945)
  Implement repair functionality for aliases colliding with indices bug (elastic#91887)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants