[Transform] Make transform _preview request cancellable#91313
Merged
przemekwitek merged 4 commits intoelastic:mainfrom Nov 8, 2022
Merged
[Transform] Make transform _preview request cancellable#91313przemekwitek merged 4 commits intoelastic:mainfrom
_preview request cancellable#91313przemekwitek merged 4 commits intoelastic:mainfrom
Conversation
a715548 to
0940a6b
Compare
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @przemekwitek, I've created a changelog YAML for you. |
droberts195
reviewed
Nov 4, 2022
.../src/main/java/org/elasticsearch/xpack/transform/action/TransportPreviewTransformAction.java
Outdated
Show resolved
Hide resolved
a1f5504 to
e9c4fb5
Compare
Collaborator
|
Hi @przemekwitek, I've created a changelog YAML for you. |
ec96fff to
9010efc
Compare
Collaborator
|
Hi @przemekwitek, I've created a changelog YAML for you. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
przemekwitek
pushed a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Nov 8, 2022
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
przemekwitek
pushed a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Nov 8, 2022
) (cherry picked from commit a8a684e) # Conflicts: # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/transform/preview_transforms.yml # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportPreviewTransformAction.java # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/rest/action/RestPreviewTransformAction.java # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/transforms/Function.java # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/transforms/common/AbstractCompositeAggFunction.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2022
przemekwitek
pushed a commit
that referenced
this pull request
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the way
_previewrequest is handled in Transform API:_previewcall cancellable by passing parent task id around_previewtime-bounded by passingtimeoutparameter aroundCloses #91286