Fork TransportClusterStateAction to MANAGEMENT#90996
Merged
original-brownbear merged 2 commits intoelastic:mainfrom Oct 19, 2022
original-brownbear:fork-cs-action
Merged
Fork TransportClusterStateAction to MANAGEMENT#90996original-brownbear merged 2 commits intoelastic:mainfrom original-brownbear:fork-cs-action
original-brownbear merged 2 commits intoelastic:mainfrom
original-brownbear:fork-cs-action
Conversation
For large cluster states the serialization of the response can take a longer time than is acceptable on a transport thread. Also, moving this to management creates a bit of a natural bottleneck via the management pool's size in case a master node is hit by a large number of concurrent requests which might also be helpful in limiting the considerable memory consumption of this transport action.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @original-brownbear, I've created a changelog YAML for you. |
| public class TransportClusterStateAction extends TransportMasterNodeReadAction<ClusterStateRequest, ClusterStateResponse> { | ||
|
|
||
| private final Logger logger = LogManager.getLogger(getClass()); | ||
| private static final Logger logger = LogManager.getLogger(TransportClusterStateAction.class); |
Contributor
Author
There was a problem hiding this comment.
unrelated but spotted this here and figured I'd fix it
henningandersen
approved these changes
Oct 19, 2022
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
As we spoke about on another channel, we should ideally remove this transport action (or at least make it not go remote) and instead server _cluster/state out of the local node (once on a new enough state version) and for CCR build dedicated endpoints. But I agree that this could (mildly) alleviate problems.
Contributor
Author
|
Thanks Henning! |
This was referenced Oct 19, 2022
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 19, 2022
For large cluster states the serialization of the response can take a longer time than is acceptable on a transport thread. Also, moving this to management creates a bit of a natural bottleneck via the management pool's size in case a master node is hit by a large number of concurrent requests which might also be helpful in limiting the considerable memory consumption of this transport action.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 3, 2023
* Fork TransportClusterStateAction to MANAGEMENT (#90996) For large cluster states the serialization of the response can take a longer time than is acceptable on a transport thread. Also, moving this to management creates a bit of a natural bottleneck via the management pool's size in case a master node is hit by a large number of concurrent requests which might also be helpful in limiting the considerable memory consumption of this transport action. * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For large cluster states the serialization of the response can take a longer time than is acceptable on a transport thread. Also, moving this to management creates a bit of a natural bottleneck via the management pool's size in case a master node is hit by a large number of concurrent requests which might also be helpful in limiting the considerable memory consumption of this transport action.