Skip to content

Clean up handshake test class#90966

Merged
justincr-elastic merged 1 commit intoelastic:mainfrom
justincr-elastic:ccx/handshake
Nov 2, 2022
Merged

Clean up handshake test class#90966
justincr-elastic merged 1 commit intoelastic:mainfrom
justincr-elastic:ccx/handshake

Conversation

@justincr-elastic
Copy link
Copy Markdown
Contributor

Remove NetworkHandle record. Change startServices to return a TransportServices instance instead. Pass in the TransportService.NOOP_TRANSPORT_INTERCEPTOR instance for all tests, except the two that need to use a DisruptingTransportInterceptor instance to modify the Elasticsearch build hash for specific failure use cases.

@justincr-elastic justincr-elastic added >test Issues or PRs that are addressing/adding tests :Distributed/CCR Issues around the Cross Cluster State Replication features Team:Distributed Meta label for distributed team. v8.6.0 labels Oct 17, 2022
@justincr-elastic justincr-elastic requested a review from a team October 17, 2022 18:12
@justincr-elastic justincr-elastic self-assigned this Oct 17, 2022
@justincr-elastic justincr-elastic requested review from DaveCTurner and removed request for a team October 17, 2022 19:16
@justincr-elastic justincr-elastic marked this pull request as ready for review October 18, 2022 03:29
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@justincr-elastic
Copy link
Copy Markdown
Contributor Author

Ping @DaveCTurner

Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justincr-elastic justincr-elastic merged commit b6b2f2c into elastic:main Nov 2, 2022
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Nov 3, 2022
* main: (1300 commits)
  update c2id/c2id-server-demo docker image to support ARM (elastic#91144)
  Allow legacy index settings on legacy indices (elastic#90264)
  Skip prevoting if single-node discovery (elastic#91255)
  Chunked encoding for snapshot status API (elastic#90801)
  Allow different decay values depending on the score function (elastic#91195)
  Fix handling indexed envelopes crossing the dateline in mvt API (elastic#91105)
  Ensure cleanups succeed in JoinValidationService (elastic#90601)
  Add overflow behaviour test for RecyclerBytesStreamOutput (elastic#90638)
  More actionable error for ancient indices (elastic#91243)
  Fix APM configuration file delete (elastic#91058)
  Clean up handshake test class (elastic#90966)
  Improve H3#hexRing logic and add H3#areNeighborCells method (elastic#91140)
  Restrict direct use of `ApplicationPrivilege` constructor (elastic#91176)
  [ML] Allow NLP truncate option to be updated when span is set (elastic#91224)
  Support multi-intersection for FieldPermissions (elastic#91169)
  Support intersecting multi-sets of queries with DocumentPermissions (elastic#91151)
  Ensure TermsEnum action works correctly with API keys (elastic#91170)
  Fix NPE in auditing authenticationSuccess for non-existing run-as user (elastic#91171)
  Ensure PKI's delegated_by_realm metadata respect run-as (elastic#91173)
  [ML] Update API documentation for anomaly score explanation (elastic#91177)
  ...

# Conflicts:
#	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackClientPlugin.java
#	x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java
#	x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java
#	x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/v2/RollupActionSingleNodeTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/CCR Issues around the Cross Cluster State Replication features Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants