Support profiling queries in Tracer#90574
Merged
DJRickyB merged 6 commits intoelastic:mainfrom Oct 4, 2022
Merged
Conversation
DJRickyB
commented
Sep 30, 2022
| permission java.io.FilePermission "/proc/self/cgroup", "read"; | ||
| permission java.io.FilePermission "/sys/fs/cgroup/-", "read"; | ||
|
|
||
| // system memory on Linux systems affected by JDK bug (#66629) |
Contributor
Author
There was a problem hiding this comment.
spotted this old permission, no longer relevant since we have minimum Java > 17
DJRickyB
commented
Sep 30, 2022
| * Has to be declared as a header copied over for tasks. | ||
| */ | ||
| public static final String TRACE_ID = "trace.id"; | ||
| public static final String TRACE_PARENT = "traceparent"; |
Contributor
Author
There was a problem hiding this comment.
I hit this in my testing, added here to be in the headers allowlist
DJRickyB
commented
Oct 3, 2022
| permission java.lang.RuntimePermission "loadLibrary.*"; | ||
| permission java.lang.RuntimePermission "getClassLoader"; | ||
| permission java.io.FilePermission "<<ALL FILES>>", "read,write"; | ||
| permission org.elasticsearch.secure_sm.ThreadPermission "modifyArbitraryThreadGroup"; |
Contributor
Author
There was a problem hiding this comment.
added due to the following error:
2022-09-30 20:33:32,521 [elastic-apm-sampling-profiler] ERROR co.elastic.apm.agent.profiler.SamplingProfiler - Stopping profiler
java.security.AccessControlException: access denied ("org.elasticsearch.secure_sm.ThreadPermission" "modifyArbitraryThreadGroup")
at java.security.AccessControlContext.checkPermission(AccessControlContext.java:485) ~[?:?]
at java.security.AccessController.checkPermission(AccessController.java:1068) ~[?:?]
at java.lang.SecurityManager.checkPermission(SecurityManager.java:411) ~[?:?]
at org.elasticsearch.secure_sm.SecureSM.checkThreadGroupAccess(SecureSM.java:195) ~[elasticsearch-secure-sm-8.5.0-SNAPSHOT.jar:?]
at org.elasticsearch.secure_sm.SecureSM.checkAccess(SecureSM.java:135) ~[elasticsearch-secure-sm-8.5.0-SNAPSHOT.jar:?]
at java.lang.ThreadGroup.checkAccess(ThreadGroup.java:335) ~[?:?]
at java.lang.ThreadGroup.enumerate(ThreadGroup.java:441) ~[?:?]
at co.elastic.apm.agent.profiler.ThreadMatcher.forEachThread(ThreadMatcher.java:41) ~[?:?]
at co.elastic.apm.agent.profiler.SamplingProfiler.restoreFilterState(SamplingProfiler.java:433) ~[?:?]
at co.elastic.apm.agent.profiler.SamplingProfiler.profile(SamplingProfiler.java:402) ~[?:?]
at co.elastic.apm.agent.profiler.SamplingProfiler.run(SamplingProfiler.java:377) ~[?:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Required additionally permitting this to the "class permissions" for modules. In actuality, this permission is preventing the ProfilingSampler from doing ThreadGroup::enumerate in order to pass threads to async-profiler, not actually working to modify them. Anyway it doesn't seem so concerning as the already-permitted-for-modules <<ALL FILES>> | read,write so I've added it
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pugnascotia
approved these changes
Oct 4, 2022
Contributor
pugnascotia
left a comment
There was a problem hiding this comment.
I wonder if we'll want to have a releasable startTrace at some point for the non-thread context case, but we can look at that in the future.
jtibshirani
added a commit
that referenced
this pull request
Oct 6, 2022
It's nice to avoid introducing too many constructors -- if we did this for all arguments, we could have a lot of "telescoping" going on. Follow up to #90574.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the necessary support, and implementation, for profiling queries in the Tracer.
In order to use the APM Agent's inferred spans functionality, the active span's context has to be open in the current thread. This PR adds context-sensitive methods to the Tracer interface, implements them in APMTracer, and makes use of them in the private
SearchService.executeQueryPhase(), which is on the stack for a lot of our most critical operations. Here is an example of the added functionality supported here (inferred spans in pink).