[Doc] Release notes for v8.4.3 by slobodanadamovic · Pull Request #90443 · elastic/elasticsearch

slobodanadamovic · 2022-09-28T07:38:04Z

Generated release notes and added highlights for 8.4.3 release.

Note: Command ./gradlew generateReleaseNotes did not generate highlights (#90398) for this patch release, so I had to manually add them.

elasticsearchmachine · 2022-09-28T07:41:14Z

Pinging @elastic/es-docs (Team:Docs)

slobodanadamovic · 2022-09-28T07:57:07Z

Preview of the changes:
https://elasticsearch_90443.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/current/release-highlights.html
https://elasticsearch_90443.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/current/es-release-notes.html
https://elasticsearch_90443.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/current/release-notes-8.4.3.html

slobodanadamovic · 2022-09-28T07:58:33Z

Coming section seem to be empty. Should I remove it?

lockewritesdocs · 2022-09-28T13:20:20Z

Coming section seem to be empty. Should I remove it?

@slobodanadamovic, it's only meant to say "Coming in 8.4.3" because the release notes are note yet published. So, working as designed 😆

slobodanadamovic · 2022-09-28T13:59:28Z

it's only meant to say "Coming in 8.4.3" because the release notes are note yet published. So, working as designed 😆

Thank you for the clarification 👍

lockewritesdocs

Added some suggested changes and opened PRs to update the changelog.yml files for affected issues.

docs/reference/release-notes/8.4.3.asciidoc

docs/reference/release-notes/highlights.asciidoc

Co-authored-by: Adam Locke <adam.locke@elastic.co>

slobodanadamovic · 2022-09-28T15:41:44Z

@elasticmachine run elasticsearch-ci/docs

lockewritesdocs · 2022-09-28T16:03:44Z

Hmm...the build is complaining of an invalid link, but I'm building locally and it's valid. Will troubleshoot.

lockewritesdocs

LGTM 🦖 Thanks @slobodanadamovic!

lockewritesdocs · 2022-09-28T16:30:20Z

@slobodanadamovic, just an FYI that this PR will need to be forward-ported to both 8.5 and master. Let me know if you'd like me to handle that work or if you want to tackle it.

lockewritesdocs · 2022-09-28T17:39:16Z

Let's hold off on merging this PR for a bit. The change introduced by #90302 might not have fixed the issue. The related issue, #89500, was reopened -- I pinged with @thecoop to ask if we should remove that fix from the release notes.

…4-3-docs

slobodanadamovic · 2022-09-29T09:44:24Z

Let's hold off on merging this PR for a bit. The change introduced by #90302 might not have fixed the issue.

Thanks Adam for spotting it. I will not merge yet.

@slobodanadamovic, just an FYI that this PR will need to be forward-ported to both 8.5 and master. Let me know if you'd like me to handle that work or if you want to tackle it.

If you have time, that would be nice. Thank you. 🙏

Note: I've regenerated notes after new BC was built. This included a new changes introduced by #90319. I'd appreciate if you could review this change as well.

elasticsearchmachine · 2022-09-29T20:40:37Z

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 90443

* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include elastic#90319 PR after creating BC2. * Remove release note for elastic#90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit 25a196f) # Conflicts: # docs/reference/release-notes.asciidoc # docs/reference/release-notes/highlights.asciidoc

lockewritesdocs · 2022-09-29T20:50:15Z

💚 All backports created successfully

Status	Branch	Result
✅	main
✅	8.5

Questions ?

Please refer to the Backport tool documentation

* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include elastic#90319 PR after creating BC2. * Remove release note for elastic#90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit 25a196f) # Conflicts: # docs/reference/release-notes.asciidoc # docs/reference/release-notes/highlights.asciidoc

* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include #90319 PR after creating BC2. * Remove release note for #90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit 25a196f) # Conflicts: # docs/reference/release-notes.asciidoc # docs/reference/release-notes/highlights.asciidoc Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com>

slobodanadamovic added 2 commits September 28, 2022 00:00

Update docs for v8.4.3 release

2ae9cbb

Update release highlights for 8.4.3 version.

1543033

slobodanadamovic added >docs General docs changes Team:Docs Meta label for docs team v8.4.3 labels Sep 28, 2022

elasticsearchmachine added the v8.4.4 label Sep 28, 2022

slobodanadamovic requested review from debadair and lockewritesdocs September 28, 2022 07:40

slobodanadamovic marked this pull request as ready for review September 28, 2022 07:40

lockewritesdocs reviewed Sep 28, 2022

View reviewed changes

docs/reference/release-notes/8.4.3.asciidoc Outdated Show resolved Hide resolved

docs/reference/release-notes/8.4.3.asciidoc Outdated Show resolved Hide resolved

docs/reference/release-notes/highlights.asciidoc Outdated Show resolved Hide resolved

slobodanadamovic and others added 3 commits September 28, 2022 17:04

Update docs/reference/release-notes/8.4.3.asciidoc

493c5bc

Co-authored-by: Adam Locke <adam.locke@elastic.co>

Update docs/reference/release-notes/8.4.3.asciidoc

02fc3e8

Co-authored-by: Adam Locke <adam.locke@elastic.co>

Update docs/reference/release-notes/highlights.asciidoc

5a7b00a

Co-authored-by: Adam Locke <adam.locke@elastic.co>

Make link external type

27b8135

lockewritesdocs self-requested a review September 28, 2022 16:25

lockewritesdocs approved these changes Sep 28, 2022

View reviewed changes

lockewritesdocs added the auto-backport-and-merge label Sep 28, 2022

slobodanadamovic added 2 commits September 29, 2022 11:37

Merge branch '8.4' of github.com:elastic/elasticsearch into update-8-…

df4710a

…4-3-docs

Update release notes to include elastic#90319 PR after creating BC2.

6ffb31f

Remove release note for elastic#90302

6533c66

Minor grammar fix

2dcd116

lockewritesdocs merged commit 25a196f into elastic:8.4 Sep 29, 2022

lockewritesdocs mentioned this pull request Sep 29, 2022

[main] [Doc] Release notes for v8.4.3 (#90443) #90538

Merged

lockewritesdocs mentioned this pull request Sep 29, 2022

[8.5] [Doc] Release notes for v8.4.3 (#90443) #90539

Merged

slobodanadamovic deleted the update-8-4-3-docs branch September 30, 2022 17:57

Conversation

slobodanadamovic commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticsearchmachine commented Sep 28, 2022

Uh oh!

slobodanadamovic commented Sep 28, 2022

Uh oh!

slobodanadamovic commented Sep 28, 2022

Uh oh!

lockewritesdocs commented Sep 28, 2022

Uh oh!

slobodanadamovic commented Sep 28, 2022

Uh oh!

lockewritesdocs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

slobodanadamovic commented Sep 28, 2022

Uh oh!

lockewritesdocs commented Sep 28, 2022

Uh oh!

lockewritesdocs left a comment

Choose a reason for hiding this comment

Uh oh!

lockewritesdocs commented Sep 28, 2022

Uh oh!

lockewritesdocs commented Sep 28, 2022

Uh oh!

slobodanadamovic commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticsearchmachine commented Sep 29, 2022

💔 Backport failed

Uh oh!

lockewritesdocs commented Sep 29, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

slobodanadamovic commented Sep 28, 2022 •

edited

Loading

slobodanadamovic commented Sep 29, 2022 •

edited

Loading