Fix ScalingThreadPoolTests for the management thread pool#90214
Merged
arteam merged 4 commits intoelastic:mainfrom Sep 22, 2022
Merged
Fix ScalingThreadPoolTests for the management thread pool#90214arteam merged 4 commits intoelastic:mainfrom
arteam merged 4 commits intoelastic:mainfrom
Conversation
If we test the defaults for the core amount of threads, we should add an exception for the management pool that now has 2 threads as the defaults instead of 1.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
droberts195
approved these changes
Sep 22, 2022
droberts195
left a comment
There was a problem hiding this comment.
LGTM
It looks like the only test failure now is because there isn't a Kibana 8.6 build available yet due to the unified snapshot build being broken for 8.6 at the moment.
Since that's now the only test failure in the PR CI I think you should merge this so that it can be backported to 8.5 ASAP. Waiting for a successful 8.6 unified snapshot before merging this will only prolong the spurious failures people are seeing.
Contributor
Author
|
Thanks David! |
Collaborator
💚 Backport successful
|
arteam
added a commit
that referenced
this pull request
Sep 22, 2022
…) (#90257) * Fix ScalingThreadPoolTests for the management thread pool (#90214) If we test the defaults for the core amount of threads, we should add an exception for the management pool that now has 2 threads as the defaults instead of 1. * Revert "Mute tests affected by #90210 (#90256)" This reverts commit b2cee96.
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Jan 19, 2023
…astic#90214)" This reverts commit 50cf18e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we test the defaults for the core amount of threads, we should add an exception for the management pool that now has 2 threads as the defaults instead of 1.
See #90193