[TEST] Fix SimpleThreadPoolIT file watcher thread name#89624
Merged
grcevski merged 1 commit intoelastic:mainfrom Aug 25, 2022
Merged
[TEST] Fix SimpleThreadPoolIT file watcher thread name#89624grcevski merged 1 commit intoelastic:mainfrom
grcevski merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
joegallo
approved these changes
Aug 25, 2022
Contributor
Author
|
Thanks Joe! |
Collaborator
💚 Backport successful
|
grcevski
added a commit
to grcevski/elasticsearch
that referenced
this pull request
Aug 25, 2022
grcevski
added a commit
that referenced
this pull request
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JDK implementation of the Watcher service is platform dependent and the two base implementations: PollingWatchService and AbstractPoller differ in the internal thread name they use: FileSystemWatchService and FileSystemWatcher, respectively.
The current SimpleThreadPoolIT test matches the JDK thread name for Linux and Windows, but you may get failures when running locally on MacOS (which uses the polling implementation).