Ensure only snapshot jdbc driver versions are testing when running check#89560
Merged
mark-vieira merged 1 commit intoelastic:mainfrom Aug 24, 2022
Merged
Ensure only snapshot jdbc driver versions are testing when running check#89560mark-vieira merged 1 commit intoelastic:mainfrom
mark-vieira merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
approved these changes
Aug 24, 2022
Contributor
breskeby
left a comment
There was a problem hiding this comment.
Lgtm. Yeah long term one of those tasks will disappear and we apply the additional conventions in a different way and not by task type.
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Aug 24, 2022
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Aug 24, 2022
…eck (elastic#89560) # Conflicts: # x-pack/plugin/sql/qa/jdbc/build.gradle
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an interesting find. Because of the way we distinguish between
StandaloneRestIntegTestTaskandRestIntegTestTaskwe were mistakenly running all BWC version tests when running thechecktask on the JDBC driver projects instead of only snapshot versions.RestTestBasePluginby convention wires allRestIntegTestTasks to thechecktask. For our BWC testing, we instead createStandaloneRestIntegTesttasks. These get fewer conventions applied, as they are typically used when manually wiring tasks, as is often the case with BWC testing. The JDBC driver tests are a form of BWC testing, but were mistakenly setup usingRestIntegTestTask. We only want to test snapshot versions when runningcheck. The full suite of versions gets testing in the periodic BWC job. This PR fixes this behavior such that we are only testing snapshot (in development) versions as expected.This is a very easy mistake to make so there definitely room for improvement here in terms of developer convenience. You can see in this build scan how the
checktask depends on the full suite of versions incorrectly.