Merged
Conversation
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
This was referenced Aug 23, 2022
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Aug 23, 2022
This commit updates the OIDC test fixture to use the latest demo docker image from https://connect2id.com. As part of this change some of the docker image demo login has changed from prior versions and the test code is updated accordingly. fixes elastic#89477 reverts elastic#89478 / e949dff.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Aug 23, 2022
This commit updates the OIDC test fixture to use the latest demo docker image from https://connect2id.com. As part of this change some of the docker image demo login has changed from prior versions and the test code is updated accordingly. fixes elastic#89477 reverts elastic#89478 / e949dff.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 23, 2022
This commit updates the OIDC test fixture to use the latest demo docker image from https://connect2id.com. As part of this change some of the docker image demo login has changed from prior versions and the test code is updated accordingly. fixes #89477 reverts #89478 / e949dff.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 23, 2022
This commit updates the OIDC test fixture to use the latest demo docker image from https://connect2id.com. As part of this change some of the docker image demo login has changed from prior versions and the test code is updated accordingly. fixes #89477 reverts #89478 / e949dff.
Contributor
|
Thanks, Jake! It's worth noting that this issue still exists since we still aren't using a docker image that provides an |
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Aug 23, 2022
This commit updates the OIDC test fixture to use the latest demo docker image from https://connect2id.com. As part of this change some of the docker image demo login has changed from prior versions and the test code is updated accordingly. fixes elastic#89477 reverts elastic#89478 / e949dff.
jakelandis
added a commit
that referenced
this pull request
Aug 23, 2022
This commit updates the OIDC test fixture to use the latest demo docker image from https://connect2id.com. As part of this change some of the docker image demo login has changed from prior versions and the test code is updated accordingly. fixes #89477 reverts #89478 / e949dff.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 3, 2022
This commit updates the c2id docker image to the latest released version. This commit also introduces a multi-stage build with the openjdk image that supports ARM architectures. So our oidc tests now supports multiple archtectures. related: elastic#89526 part of: elastic#71378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the OIDC test fixture to use the latest demo docker image
from https://connect2id.com. As part of this change some of the docker image demo
login has changed from prior versions and the test code is updated accordingly.
fixes #89477
reverts #89478 / e949dff.
To figure out the required changes I setup a local proxy to watch traffic and manually executed some of the workflows and adjusted the test setup accordingly.
When run as a suite of tests depending on order some tests would fail... I found that setting op.authz.alwaysPromptForConsent=true and op.authz.alwaysPromptForAuth=true allows for the tests to pass consistently.
Buildscan with only these tests: https://gradle-enterprise.elastic.co/s/xnysxq5b2m6za