Skip to content

[DOCS] Update add node section#89393

Merged
lockewritesdocs merged 2 commits intoelastic:mainfrom
lockewritesdocs:docs__update-add-nodes
Aug 25, 2022
Merged

[DOCS] Update add node section#89393
lockewritesdocs merged 2 commits intoelastic:mainfrom
lockewritesdocs:docs__update-add-nodes

Conversation

@lockewritesdocs
Copy link
Copy Markdown
Contributor

@lockewritesdocs lockewritesdocs commented Aug 16, 2022

Updates the verbiage in Add and remove nodes in your cluster to reference the section for enrolling additional nodes in your cluster.

Preview link: https://elasticsearch_89393.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/add-elasticsearch-nodes.html

Closes #86334

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Aug 16, 2022
@lockewritesdocs lockewritesdocs requested a review from ywangd August 16, 2022 18:20
Copy link
Copy Markdown
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether it would be better to embed the content of the "enroll-nodes" page instead of linking to it. This page is already titled as "Add and remove nodes in your cluster". It feels awkward that it has to link to another page that has almost the same (sub) title.

Related, but not directly for this PR, is that I noticed the same "enroll-nodes" content is embedded twice in the Starting Elasticsearch page (first and second). I think linking is actually a better option here since (1) the page is mostly about starting up not additional nodes and (2) avoid repetition.

@lockewritesdocs
Copy link
Copy Markdown
Contributor Author

I wonder whether it would be better to embed the content of the "enroll-nodes" page instead of linking to it. This page is already titled as "Add and remove nodes in your cluster".

I updated the page to include this content directly, rather than linking to it.

@lockewritesdocs lockewritesdocs requested a review from ywangd August 24, 2022 18:02
Copy link
Copy Markdown
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lockewritesdocs lockewritesdocs merged commit 2fad061 into elastic:main Aug 25, 2022
@lockewritesdocs lockewritesdocs deleted the docs__update-add-nodes branch August 25, 2022 12:51
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
8.3
8.4

lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Aug 25, 2022
* [DOCS] Update add node section

* Include information for enrolling nodes
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Aug 25, 2022
* [DOCS] Update add node section

* Include information for enrolling nodes
elasticsearchmachine pushed a commit that referenced this pull request Aug 25, 2022
* [DOCS] Update add node section

* Include information for enrolling nodes
elasticsearchmachine pushed a commit that referenced this pull request Aug 25, 2022
* [DOCS] Update add node section

* Include information for enrolling nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes Team:Docs Meta label for docs team v8.3.4 v8.4.1 v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] "Add and remove nodes" docs should link to security "Enroll additional nodes" docs

3 participants