Merged
Conversation
Contributor
Author
|
@elasticmachine elasticsearch-ci/part-2 |
5dbad9d to
5d67636
Compare
Contributor
Author
|
@elasticmachine update branch |
masseyke
reviewed
Aug 15, 2022
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
andreidan
reviewed
Sep 1, 2022
Contributor
andreidan
left a comment
There was a problem hiding this comment.
Thanks for iterating on this Mary
Left a round of comments (still testing this) but this looks great !
server/src/main/java/org/elasticsearch/health/node/DiskHealthInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/DiskHealthInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
andreidan
approved these changes
Sep 5, 2022
Contributor
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for iterating on this Mary 🚀
server/src/main/java/org/elasticsearch/health/node/HealthInfoCache.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
andreidan
reviewed
Sep 5, 2022
server/src/main/java/org/elasticsearch/health/node/LocalHealthMonitor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 8, 2022
This PR adds FetchHealthInfoCacheAction, which fetches the data sent to the health node by the UpdateHealthInfoCacheAction (#89275).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we are introducing the last piece of the push interaction model in which every node monitors their health and sends it to the health node in the following situations:
Implementation details
To synchronize the code we use an atomic reference to the last successfully reported health info. This variable gets updated in the following ways:
nulltoo.