Skip to content

Health info overview#89275

Merged
gmarouli merged 59 commits intoelastic:mainfrom
gmarouli:health-info-overview
Sep 5, 2022
Merged

Health info overview#89275
gmarouli merged 59 commits intoelastic:mainfrom
gmarouli:health-info-overview

Conversation

@gmarouli
Copy link
Copy Markdown
Contributor

In this PR we are introducing the last piece of the push interaction model in which every node monitors their health and sends it to the health node in the following situations:

  • when it changes from the last reported state
  • when there is a new health node

Implementation details

To synchronize the code we use an atomic reference to the last successfully reported health info. This variable gets updated in the following ways:

  • it gets updated if the health info was successfully received by the health node and last reported value hasn't changed since this method read from it.
  • it gets reset (set to null without any preconditions) when there is a change in the health node. Effectively, when the health node changes, the health node doesn't have any health data so it makes sense for the last successfully reported health info to be null too.

@gmarouli
Copy link
Copy Markdown
Contributor Author

@elasticmachine elasticsearch-ci/part-2

@gmarouli gmarouli force-pushed the health-info-overview branch from 5dbad9d to 5d67636 Compare August 12, 2022 14:21
@gmarouli
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@gmarouli
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@gmarouli gmarouli added >non-issue Team:Data Management (obsolete) DO NOT USE. This team no longer exists. :Distributed/Health Issues for the health report API labels Aug 21, 2022
@gmarouli gmarouli marked this pull request as ready for review August 21, 2022 11:53
@gmarouli
Copy link
Copy Markdown
Contributor Author

gmarouli commented Sep 1, 2022

@elasticmachine update branch

@gmarouli gmarouli marked this pull request as ready for review September 1, 2022 12:41
@gmarouli gmarouli requested a review from masseyke September 1, 2022 13:09
Copy link
Copy Markdown
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this Mary

Left a round of comments (still testing this) but this looks great !

Copy link
Copy Markdown
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmarouli
Copy link
Copy Markdown
Contributor Author

gmarouli commented Sep 5, 2022

@elasticmachine update branch

@gmarouli gmarouli requested a review from andreidan September 5, 2022 11:04
Copy link
Copy Markdown
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for iterating on this Mary 🚀

@gmarouli
Copy link
Copy Markdown
Contributor Author

gmarouli commented Sep 5, 2022

@elasticmachine update branch

@gmarouli
Copy link
Copy Markdown
Contributor Author

gmarouli commented Sep 5, 2022

@elasticmachine run elasticsearch-ci/part-1

@gmarouli gmarouli merged commit e63d70b into elastic:main Sep 5, 2022
elasticsearchmachine pushed a commit that referenced this pull request Sep 8, 2022
This PR adds FetchHealthInfoCacheAction, which fetches the data sent to
the health node by the UpdateHealthInfoCacheAction (#89275).
@gmarouli gmarouli deleted the health-info-overview branch August 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Health Issues for the health report API >non-issue Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants