Add support for reading stable plugin descriptors#88731
Merged
elasticsearchmachine merged 13 commits intoelastic:mainfrom Jul 26, 2022
Merged
Add support for reading stable plugin descriptors#88731elasticsearchmachine merged 13 commits intoelastic:mainfrom
elasticsearchmachine merged 13 commits intoelastic:mainfrom
Conversation
The new stable plugin api will have a slightly different descriptor file format. This commit prepares for stable plugins by adding support for reading those new files. The basic info for a plugin is the same like name and version info. Other stuff like classname are not necessary. The one additional property specific to the new plugins is "modular", which indicates whether the jars of the plugin should be loaded as named modules (this is akin to setting the module path when running java).
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
grcevski
approved these changes
Jul 23, 2022
Contributor
grcevski
left a comment
There was a problem hiding this comment.
LGTM! Looks great, I really like how all the tests simply run for both. It looks like there are two more tests that need to be adjusted for the new missing descriptors error message.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 26, 2022
A forgotten piece of elastic#88731 is whether a plugin descriptor in memory came from a stable or internal descriptor. This commit adds a flag for that. Note that this is implied by the file that was loaded, so no new property is needed.
rjernst
added a commit
that referenced
this pull request
Jul 26, 2022
A forgotten piece of #88731 is whether a plugin descriptor in memory came from a stable or internal descriptor. This commit adds a flag for that. Note that this is implied by the file that was loaded, so no new property is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new stable plugin api will have a slightly different descriptor file
format. This commit prepares for stable plugins by adding support for
reading those new files. The basic info for a plugin is the same like
name and version info. Other stuff like classname are not necessary. The
one additional property specific to the new plugins is "modular", which
indicates whether the jars of the plugin should be loaded as named
modules (this is akin to setting the module path when running java).