Enable synthetic source support on constant keyword fields#88603
Merged
romseygeek merged 2 commits intoelastic:masterfrom Jul 19, 2022
Merged
Enable synthetic source support on constant keyword fields#88603romseygeek merged 2 commits intoelastic:masterfrom
romseygeek merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Hi @romseygeek, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
jpountz
reviewed
Jul 19, 2022
Contributor
jpountz
left a comment
There was a problem hiding this comment.
I'm not qualified to do a full review, but the change makes sense to me and properly tests the corner case when the constant value has not been configured yet, so this is good as far as I can tell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements synthetic source support on constant keyword fields,
which will now always emit their value as part of the retrieved source.