Remove usages of BucketCollector#getLeafCollector(LeafReaderContext)#88414
Merged
iverase merged 9 commits intoelastic:masterfrom Jul 11, 2022
Merged
Remove usages of BucketCollector#getLeafCollector(LeafReaderContext)#88414iverase merged 9 commits intoelastic:masterfrom
iverase merged 9 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
not-napoleon
approved these changes
Jul 11, 2022
Member
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning this up!
| public void collect(int doc, long bucket) throws IOException { | ||
| if (context == null) { | ||
| context = aggCtx.getLeafReaderContext(); | ||
| if (BestBucketsDeferringCollector.this.aggCtx == null) { |
Member
There was a problem hiding this comment.
Thanks for clarifying this on slack. I think renaming would be clearer here.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jul 12, 2022
* upstream/master: Pass IndexMetadata to AllocationDecider.can_remain (elastic#88453) [TSDB] Cache rollup bucket timestamp to reduce rounding cost (elastic#88420) Correct some typos/mistakes in comments/docs (elastic#88446) Make ClusterInfo use immutable maps in all cases (elastic#88447) Reduce map lookups (elastic#88418) Don't index geo_shape field in AbstractBuilderTestCase (elastic#88437) Remove usages of TestGeoShapeFieldMapperPlugin from enrich module (elastic#88440) Fix test memory leak (elastic#88362) Improve error when sorting on incompatible types (elastic#88399) Remove usages of BucketCollector#getLeafCollector(LeafReaderContext) (elastic#88414) Mute ReactiveStorageIT::testScaleWhileShrinking (elastic#88431) Clarify snapshot docs on archive indices (elastic#88417) [Stack Monitoring] Switch cgroup memory fields to keyword (elastic#88260) Fix RealmIdentifier XContent parser (elastic#88410) Make LoggedExec gradle task configuration cache compatible (elastic#87621) Update CorruptedFileIT so that it passes with new allocation strategy (elastic#88314) Update RareClusterStateIT to work with the new shards allocator (elastic#87922) Ensure CreateApiKey always creates a new document (elastic#88413) # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/RollupShardIndexer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method BucketCollector#getLeafCollector(LeafReaderContext) should be removed in favour of BucketCollector#getLeafCollector(AggregationExecutionContext). This PR prepares that action by removing the usages of the first method with the second.