[ML] Rename trained model metadata after full cluster upgrade#87806
Merged
dimitris-athanasiou merged 2 commits intoelastic:masterfrom Jun 17, 2022
Conversation
In elastic#85503 we renamed trained model allocations to assignments. However, it is important to wait for the full cluster to be upgraded before we rewrite the cluster state so that there are no undesired side-effects in a mixed cluster.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
reviewed
Jun 17, 2022
| .removeCustom(TrainedModelAssignmentMetadata.DEPRECATED_NAME); | ||
| } else { | ||
| metadata.putCustom(TrainedModelAssignmentMetadata.DEPRECATED_NAME, modelAssignments.build()) | ||
| .removeCustom(TrainedModelAssignmentMetadata.NAME); |
There was a problem hiding this comment.
Is this removal necessary? Surely it's only needed if we've already released software that prematurely upgrades?
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jun 17, 2022
…c#87806) In elastic#85503 we renamed trained model allocations to assignments. However, it is important to wait for the full cluster to be upgraded before we rewrite the cluster state so that there are no undesired side-effects in a mixed cluster.
Collaborator
💚 Backport successful
|
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jun 18, 2022
This is a follow-up fix to elastic#87806.
dimitris-athanasiou
added a commit
that referenced
this pull request
Jun 18, 2022
This is a follow-up fix to #87806.
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jun 18, 2022
This is a follow-up fix to elastic#87806.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #85503 we renamed trained model allocations to assignments.
However, it is important to wait for the full cluster to be
upgraded before we rewrite the cluster state so that there are
no undesired side-effects in a mixed cluster.