Make CBE message creation more robust#87687
Merged
elasticsearchmachine merged 8 commits intoelastic:masterfrom Jun 21, 2022
Merged
Make CBE message creation more robust#87687elasticsearchmachine merged 8 commits intoelastic:masterfrom
elasticsearchmachine merged 8 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
Child circuit breakers rely on proper matching of acquire/release pairs. This can be tricky to get right. If we get it wrong and accidentally double-release a CB then it may end up with a negative `used` value. This is definitely a bad situation in which to find ourselves, but today in production it's made a whole lot worse because it causes exceptions on every attempt to report a `CircuitBreakerStats` or to construct a parent `CircuitBreakingException`. This commit makes the message construction and stats serialization a little more robust so that it's clearer what is going on in production.
c15655e to
c87f62f
Compare
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
grcevski
approved these changes
Jun 16, 2022
Contributor
grcevski
left a comment
There was a problem hiding this comment.
LGTM! Does it make sense to log a warning of some kind when we encounter a negative value with a stack trace? I'm hoping here that with enough stack traces we could at least pinpoint the general area where we have this double decrement, or perhaps that won't help us much.
Member
Author
|
Sure, I added such logging in 5ff3a42. This should at least tell us which CB is affected in a way that's easy to search across all clusters' logs. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 21, 2022
Child circuit breakers rely on proper matching of acquire/release pairs. This can be tricky to get right. If we get it wrong and accidentally double-release a CB then it may end up with a negative `used` value. This is definitely a bad situation in which to find ourselves, but today in production it's made a whole lot worse because it causes exceptions on every attempt to report a `CircuitBreakerStats` or to construct a parent `CircuitBreakingException`. This commit makes the message construction and stats serialization a little more robust so that it's clearer what is going on in production. Relates elastic#86059.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 21, 2022
Child circuit breakers rely on proper matching of acquire/release pairs. This can be tricky to get right. If we get it wrong and accidentally double-release a CB then it may end up with a negative `used` value. This is definitely a bad situation in which to find ourselves, but today in production it's made a whole lot worse because it causes exceptions on every attempt to report a `CircuitBreakerStats` or to construct a parent `CircuitBreakingException`. This commit makes the message construction and stats serialization a little more robust so that it's clearer what is going on in production. Relates elastic#86059. Backport of elastic#87687.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 21, 2022
Child circuit breakers rely on proper matching of acquire/release pairs. This can be tricky to get right. If we get it wrong and accidentally double-release a CB then it may end up with a negative `used` value. This is definitely a bad situation in which to find ourselves, but today in production it's made a whole lot worse because it causes exceptions on every attempt to report a `CircuitBreakerStats` or to construct a parent `CircuitBreakingException`. This commit makes the message construction and stats serialization a little more robust so that it's clearer what is going on in production. Relates #86059.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 21, 2022
Child circuit breakers rely on proper matching of acquire/release pairs. This can be tricky to get right. If we get it wrong and accidentally double-release a CB then it may end up with a negative `used` value. This is definitely a bad situation in which to find ourselves, but today in production it's made a whole lot worse because it causes exceptions on every attempt to report a `CircuitBreakerStats` or to construct a parent `CircuitBreakingException`. This commit makes the message construction and stats serialization a little more robust so that it's clearer what is going on in production. Relates #86059. Backport of #87687.
DaveCTurner
added a commit
that referenced
this pull request
Jun 21, 2022
This reverts commit 9ff9026.
DaveCTurner
added a commit
that referenced
this pull request
Jun 21, 2022
Member
Author
|
Reverted due to test failures - will be reinstated by #87881. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child circuit breakers rely on proper matching of acquire/release pairs.
This can be tricky to get right. If we get it wrong and accidentally
double-release a CB then it may end up with a negative
usedvalue.This is definitely a bad situation in which to find ourselves, but today
in production it's made a whole lot worse because it causes exceptions
on every attempt to report a
CircuitBreakerStatsor to construct aparent
CircuitBreakingException.This commit makes the message construction and stats serialization a
little more robust so that it's clearer what is going on in production.
Relates #86059.