Synthetic source: tests for disabling subobjects#87261
Merged
nik9000 merged 1 commit intoelastic:masterfrom Jun 1, 2022
Merged
Synthetic source: tests for disabling subobjects#87261nik9000 merged 1 commit intoelastic:masterfrom
nik9000 merged 1 commit intoelastic:masterfrom
Conversation
This adds some paranoid tests for synthetic source with disabling subobjects, as added by elastic#86166. It turns out that synthetic source does exactly what you'd expect with disabling subobjects - it creates fields with dots in their names. This adds tests for that.
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
Member
Author
I was super happy that it "just works". I didn't realize |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jun 1, 2022
This adds some paranoid tests for synthetic source with disabling subobjects, as added by elastic#86166. It turns out that synthetic source does exactly what you'd expect with disabling subobjects - it creates fields with dots in their names. This adds tests for that.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 1, 2022
This adds some paranoid tests for synthetic source with disabling subobjects, as added by #86166. It turns out that synthetic source does exactly what you'd expect with disabling subobjects - it creates fields with dots in their names. This adds tests for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some paranoid tests for synthetic source with disabling
subobjects, as added by #86166. It turns out that synthetic source does
exactly what you'd expect with disabling subobjects - it creates fields
with dots in their names. This adds tests for that.