Batch execute template and pipeline cluster state operations#86017
Batch execute template and pipeline cluster state operations#86017dakrone merged 7 commits intoelastic:masterfrom
Conversation
…te-and-pipeline-CS
…te-and-pipeline-CS
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @dakrone, I've created a changelog YAML for you. |
martijnvg
left a comment
There was a problem hiding this comment.
The PR looks good to me.
I do wonder about testing.
Each type of operation is tested (e.g. putting a pipeline) on the unit level and integration level. I think batching implementation is tested as well in ClusterStateService is tested as well. So I think we're good here, right?
| } | ||
| } | ||
|
|
||
| public interface PutListener { |
There was a problem hiding this comment.
👍 to see these listeners being replaced by ActionListener
I think so too, I think adding a test specifically for this would add a ton of complexity. |
Yes, I had a similar feeling that these tests require a lot of work without adding much benefit. |
|
For future reference you can use |
This commit changes the cluster state operations for templates (legacy, component, and composable) as well as ingest pipelines to be bulk executed. This means that they can be processed much faster when creating/updating many simultaneously.
Relates to #77505