Aggregation Execution Context add timestamp provider#85850
Merged
csoulios merged 6 commits intoelastic:masterfrom Apr 18, 2022
Merged
Aggregation Execution Context add timestamp provider#85850csoulios merged 6 commits intoelastic:masterfrom
csoulios merged 6 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Contributor
|
@elasticmachine ok to test |
csoulios
approved these changes
Apr 13, 2022
Contributor
|
@elasticmachine update branch |
imotov
approved these changes
Apr 16, 2022
Contributor
imotov
left a comment
There was a problem hiding this comment.
LGTM, except I don't think we need IOException there. I suspect we can convert CheckedSupplier to Supplier in case of tsid as well. I think it is CheckedSupplier for purely historical reasons.
| public AggregationExecutionContext( | ||
| LeafReaderContext leafReaderContext, | ||
| CheckedSupplier<BytesRef, IOException> tsidProvider, | ||
| CheckedSupplier<Long, IOException> timestampProvider |
Contributor
There was a problem hiding this comment.
Why is this a checked supplier? Under what condition can it ever throw IOException?
Contributor
Author
There was a problem hiding this comment.
LGTM, except I don't think we need IOException there. I suspect we can convert CheckedSupplier to Supplier in case of tsid as well. I think it is CheckedSupplier for purely historical reasons.
Yeah, I also think Supplier is better, I have converted CheckedSupplier to Supplier for timestamp and tsid.
Contributor
Author
|
@elasticmachine update branch |
Contributor
|
Thank you for this contribution @weizijun |
Contributor
Author
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Apr 21, 2022
* master: (104 commits) fix: ordering terms aggregation on top metrics null values (elastic#85774) Fix up whitespace error introduced in elastic#85948 More docs re. removing cluster.initial_master_nodes (elastic#85948) [Test] Remove API key methods from HLRC (elastic#85802) Remove references to bootstrap.system_call_filter (elastic#85964) Move docker cgroup override to SystemJvmOptions (elastic#85960) Add connection accounting tests (elastic#85966) Remove MacOS from platform support testing matrix Remove custom KnnVectorFieldExistsQuery (elastic#85945) Relax data path deprecations from critical to warn (elastic#85952) Remove hppc from some "common" classes (elastic#85957) Move docker env var settings handling out of bash (elastic#85913) Remove hppc from task manager (elastic#85889) [ML] rename trained model allocations to assignments (elastic#85503) Remove hppc from multi*shard request and responses (elastic#85888) Consolidating logging initialization in cli launcher (elastic#85920) Convert license tools to use unified cli entrypoint (elastic#85919) Add noop detection to node shutdown actions (elastic#85914) Adjust SQL expended test output TSDB: Add timestamp provider to AggregationExecutionContext (elastic#85850) ... # Conflicts: # server/src/main/java/org/elasticsearch/search/aggregations/AggregationExecutionContext.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As LeafWalker already get the timestamp from doc values, It can add a timestampProvider in the AggregationExecutionContext.
It's useful in the time serise downsampling sense. downsampling collect can get the timestamp from the AggregationExecutionContext.
And It will have other more use case.