[Tests] Enhance multi cluster search test skipping#85566
Merged
cbuescher merged 7 commits intoelastic:masterfrom Apr 20, 2022
Merged
[Tests] Enhance multi cluster search test skipping#85566cbuescher merged 7 commits intoelastic:masterfrom
cbuescher merged 7 commits intoelastic:masterfrom
Conversation
Currently the "skip" section in out rest yaml tests take into account the lowest minor version of nodes in the connected local cluster. For some multi cluster CCS test we will also need the ability to skip certain tests based on the connected remote cluster version, e.g. if in bwc tests some functionality isn't available yet on some bwc versions we test against. This change adds that ability to yaml rest test in the :qa:multi-cluster-search module. Relates to elastic#84481
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
javanna
suggested changes
Apr 1, 2022
Contributor
javanna
left a comment
There was a problem hiding this comment.
I left some comments, thanks @cbuescher
...ml-rest-runner/src/main/java/org/elasticsearch/test/rest/yaml/ESClientYamlSuiteTestCase.java
Show resolved
Hide resolved
...cluster-search/src/test/java/org/elasticsearch/search/MultiClusterSearchYamlTestSuiteIT.java
Outdated
Show resolved
Hide resolved
...st-runner/src/main/java/org/elasticsearch/test/rest/yaml/ClientYamlTestExecutionContext.java
Outdated
Show resolved
Hide resolved
...cluster-search/src/test/java/org/elasticsearch/search/MultiClusterSearchYamlTestSuiteIT.java
Show resolved
Hide resolved
Member
Author
|
@javanna I pushed changes that I think simplify this PR quite a bit, I think this is ready for another look |
ab237f2 to
d84d7f4
Compare
javanna
approved these changes
Apr 20, 2022
...cluster-search/src/test/java/org/elasticsearch/search/MultiClusterSearchYamlTestSuiteIT.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks @javanna for the review. |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Apr 21, 2022
Currently the "skip" section in out rest yaml tests take into account the lowest minor version of nodes in the connected local cluster. For some multi cluster CCS test we will also need the ability to skip certain tests based on the connected remote cluster version, e.g. if in bwc tests some functionality isn't available yet on some bwc versions we test against. This change adds that ability to yaml rest test in the :qa:multi-cluster-search module. Relates to elastic#84481
cbuescher
pushed a commit
that referenced
this pull request
Apr 21, 2022
Currently the "skip" section in out rest yaml tests take into account the lowest minor version of nodes in the connected local cluster. For some multi cluster CCS test we will also need the ability to skip certain tests based on the connected remote cluster version, e.g. if in bwc tests some functionality isn't available yet on some bwc versions we test against. This change adds that ability to yaml rest test in the :qa:multi-cluster-search module. Relates to #84481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the "skip" section in out rest yaml tests take into account the lowest
minor version of nodes in the connected local cluster. For some multi cluster
CCS test we will also need the ability to skip certain tests based on the
connected remote cluster version, e.g. if in bwc tests some functionality isn't
available yet on some bwc versions we test against. This change adds that
ability to yaml rest test in the :qa:multi-cluster-search module.
Relates to #84481