Strengthen elasticsearch plugin version check#85340
Merged
grcevski merged 5 commits intoelastic:masterfrom Mar 28, 2022
Merged
Conversation
When a plugin specifies an elasticsearch version with an empty string in their plugin-descriptor.properties file, we don't enforce the version check. This PR ensures that we check the version string for empty as well as null value.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @grcevski, I've created a changelog YAML for you. |
rjernst
approved these changes
Mar 28, 2022
| "version", | ||
| "1.0", | ||
| "elasticsearch.version", | ||
| "" |
Member
There was a problem hiding this comment.
Since we are using the Strings util, should we test for non zero length but still empty?
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 28, 2022
When a plugin specifies an elasticsearch version with an empty string in their plugin-descriptor.properties file, we don't enforce the version check. This PR ensures that we check the version string for empty as well as null value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plugin specifies an elasticsearch version with an empty string
in their plugin-descriptor.properties file, we don't enforce the
version check. This PR ensures that we check the version string for
empty as well as null value.
Closes #85336