Check feature flag before registering JWT settings#84740
Check feature flag before registering JWT settings#84740elasticsearchmachine merged 6 commits intoelastic:masterfrom
Conversation
The JWT feature flag would control whether the JWT realm was defined as a configurable internal realm, but was not checked before the JWT realm settings were registered. This means that it was possible to defined a JWT realm in YML even if the realm wasn't enabled in this build This change adds the feature flag check to the settings registration
|
Pinging @elastic/es-security (Team:Security) |
|
The release tests will fail until #84738 is merged |
|
@elasticmachine update branch |
|
Can you confirm there are no other missing checks? It might be worthwhile to set XpackSettings.JWT_REALM_FEATURE_FLAG_ENABLED=false locally and run all tests, or put that in a throwaway PR and let CI tests verify it. After you confirm no other changes, I will update #84845 for removing this feature flag. |
|
@elasticmachine update branch |
That doesn't do anything. You can only turn on the feature flag - you can't turn it off. The |
The JWT feature flag would control whether the JWT realm was defined
as a configurable internal realm, but was not checked before the JWT
realm settings were registered.
This means that it was possible to defined a JWT realm in YML even if
the realm wasn't enabled in this build
This change adds the feature flag check to the settings registration