Check feature flag before creating JWT test realm#84738
Check feature flag before creating JWT test realm#84738elasticsearchmachine merged 3 commits intoelastic:masterfrom
Conversation
SecurityRealmSettingsTests would fail on release builds because the JWT realm is not registered as an internal realm Resolves: elastic#84698
|
Pinging @elastic/es-security (Team:Security) |
ywangd
left a comment
There was a problem hiding this comment.
LGTM
This works. But I wonder why you didn't choose to enable it explicitly so the test runs on all builds?
Because in a release build the feature is supposed to be disabled, so it felt better to test the intended behaviour rather than force it to use a different behaviour. The fact that we run this tests with the realm disabled actually uncovered the bug to be fixed in #84740 because this test failed when comparing the configured settings to the expected realm types, but it should have failed when configuring the realm (because the setting shouldn't exist). |
|
@elasticsearchmachine run elasticsearch-ci/release-tests please :qa:smoke-test-http:integTest
|
|
@elasticmachine update branch |
SecurityRealmSettingsTests would fail on release builds because
the JWT realm is not registered as an internal realm
Resolves: #84698