Remove existing indices/datastreams/aliases before simulating index template#84675
Merged
dakrone merged 4 commits intoelastic:masterfrom Mar 8, 2022
Merged
Conversation
…emplate Previously when constructing the "fake" response when simulating an index template (`/_index_template/_simulate_index/<myindexname>`) an error would be thrown if there was an index, alias, or data stream already existing with the provided index name. This commit makes it so that simulating an index that may already exist treats it as though it was a new creation of the index. Resolves elastic#84256
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @dakrone, I've created a changelog YAML for you. |
andreidan
approved these changes
Mar 7, 2022
Contributor
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this Lee
Member
Author
|
@elasticmachine update branch |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 8, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 8, 2022
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 8, 2022
…emplate (elastic#84675) # Conflicts: # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/data_stream/180_simulate_existing_data_stream.yml
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 8, 2022
…emplate (elastic#84675) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/indices.simulate_index_template/10_basic.yml # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/data_stream/180_simulate_existing_data_stream.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 8, 2022
…index template (#84675) (#84769) * Remove existing indices/datastreams/aliases before simulating index template (#84675) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/indices.simulate_index_template/10_basic.yml # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/data_stream/180_simulate_existing_data_stream.yml * Fix backport typo issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when constructing the "fake" response when simulating an index
template (
/_index_template/_simulate_index/<myindexname>) an error would be thrown if there was anindex, alias, or data stream already existing with the provided index name. This commit makes it so
that simulating an index that may already exist treats it as though it was a new creation of the
index.
Resolves #84256