Remove all "user" related methods from HLRC#84011
Merged
tvernum merged 5 commits intoelastic:masterfrom Feb 16, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
66 tasks
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
Removes the following methods from the SecurityClient component of the High Level Rest Client - putUser - deleteUser - changePassword - authenticate As part of this change, I renamed the SecurityClientTestHelper class to TestSecurityClient and made it a real object rather than a set of utility methods. This was needed because different tests need different RequestOptions objects, but passing it into every method made it cumbersome. The code is clearer if we use a field in the test client itself. Relates: elastic#83423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the following methods from the
SecurityClientcomponent of the High Level Rest ClientputUserdeleteUserchangePasswordauthenticateAs part of this change, I renamed the
SecurityClientTestHelperclass toTestSecurityClientand made it a real object rather than a set of utility methods.This was needed because different tests need different
RequestOptionsobjects, but passing it into every method made it cumbersome.The code is clearer if we use a field in the test client itself.
Relates: #83423