Merged
Conversation
arteam
reviewed
Feb 16, 2022
Contributor
arteam
left a comment
There was a problem hiding this comment.
LGTM! I've left a couple of stylistic comments
| } | ||
| } | ||
|
|
||
| static class Resolver extends AddressResolverGroup<InetSocketAddress> { |
Contributor
There was a problem hiding this comment.
Isn't this resolver is the same as DefaultAddressResolverGroup.INSTANCE?
Contributor
Author
There was a problem hiding this comment.
You're right, this is a leftover from when I was tracking down the issue with the connection pool 👍
| // The underlying http client uses this as part of the connection pool key, | ||
| // hence we need to use the same instance across all the client instances | ||
| // to avoid creating multiple connection pools. | ||
| record NioLoopResources(EventLoopGroup eventLoopGroup) implements LoopResources { |
Contributor
There was a problem hiding this comment.
I feel that we don't need to create a separate class for that, but can just use a lambda expression in the constructor
this.nioLoopResources = useNative -> eventLoopGroup
Contributor
Contributor
|
Ping @fcofdez, I think we are good to go with this PR. |
Contributor
Author
|
ops! This fell through the cracks! I'll merge it! |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
I have to fix #84231 before merging this one (it's related to the test infrastructure) |
Contributor
1a1669f to
8cb9f55
Compare
Member
|
@fcofdez The example-plugins CI check failure can be ignored for now, it is due to the recent version bump. This PR should be good to merge. I think it should go back to 8.2 and 7.17. |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Apr 13, 2022
…n/elasticsearch into datastream-reuse-pipeline-source * 'datastream-reuse-pipeline-source' of github.com:weizijun/elasticsearch: (28 commits) Add JDK 19 to Java testing matrix [ML] add nlp config update serialization tests (elastic#85867) [ML] A text categorization aggregation that works like ML categorization (elastic#80867) [ML] Fix serialisation of text embedding updates (elastic#85863) TSDB: fix wrong initial value of tsidOrd in TimeSeriesIndexSearcher (elastic#85713) Enforce external id uniqueness during DesiredNode construction (elastic#84227) Fix Intellij integration (elastic#85866) Upgrade Azure SDK to version 12.14.4 (elastic#83884) [discovery-gce] Fix initialisation of transport in FIPS mode (elastic#85817) Remove unnecessary docs/changelog/85534.yaml Prevent ThreadContext header leak when sending response (elastic#68649) Add support for impact_areas to health impacts (elastic#85830) Reduce port range re-use in tests (elastic#85777) Fix TranslogTests#testStats (elastic#85828) Remove hppc from cat allocation api (elastic#85842) Fix BuildTests serialization (elastic#85827) Use urgent priority for node shutdown cluster state update (elastic#85838) Remove Task classes from HLRC (elastic#85835) Remove unused migration classes (elastic#85834) Remove uses of Charset name parsing (elastic#85795) ...
Contributor
Contributor
Author
Contributor
Member
|
Ah! I should have LinkedIn that publicly! I'm slipping.
…On Mon, Apr 25, 2022, 6:47 AM weizijun ***@***.***> wrote:
Jackson has been upgraded separately in this PR #86051
<#86051> cc @weizijun
<https://github.com/weizijun>
Yeah, Nik told me about this PR, thanks!
—
Reply to this email directly, view it on GitHub
<#83884 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXISQAHP3EY5RKA5FBMLVGZZ4BANCNFSM5OK5TLLQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
fcofdez
added a commit
that referenced
this pull request
Apr 26, 2022
In this version jackson was upgraded to the version 2.13.2.1 that we were using before. See https://github.com/Azure/azure-sdk-for-java/releases/tag/azure-core_1.27.0 Without the upgrade, the third party SAS tests were failing, once upgraded the tests pass again, I think that we were hitting some incompatibility with the jackson version that we were providing. Relates #83884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.