Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Member
Author
|
This is nowhere near exhaustive of the features that |
69 tasks
This adds a pile of extra REST tests for the `top_hits` aggregation which is useful because this is how we do mixed version cluster testing. And backwards compatibility testing. And forwards compatibility testing.
not-napoleon
approved these changes
Feb 28, 2022
Member
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM. Should this get backported to 7.17?
Member
Author
It can. I hadn't planned on it just for time's sake. But I'll see if the backport robot can do it. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 28, 2022
This adds a pile of extra REST tests for the `top_hits` aggregation which is useful because this is how we do mixed version cluster testing. And backwards compatibility testing. And forwards compatibility testing.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 28, 2022
This adds a pile of extra REST tests for the `top_hits` aggregation which is useful because this is how we do mixed version cluster testing. And backwards compatibility testing. And forwards compatibility testing.
nik9000
added a commit
that referenced
this pull request
Feb 28, 2022
nik9000
added a commit
that referenced
this pull request
Feb 28, 2022
* REST tests for top_hits (#83690) This adds a pile of extra REST tests for the `top_hits` aggregation which is useful because this is how we do mixed version cluster testing. And backwards compatibility testing. And forwards compatibility testing. * After 7.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a pile of extra REST tests for the
top_hitsaggregationwhich is useful because this is how we do mixed version cluster testing.
And backwards compatibility testing. And forwards compatibility testing.