Cleanup DataTierAllocationDecider#83572
Merged
original-brownbear merged 2 commits intoelastic:masterfrom Feb 7, 2022
original-brownbear:cleanup-data-tier-alloc-decider
Merged
Cleanup DataTierAllocationDecider#83572original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:cleanup-data-tier-alloc-decider
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:cleanup-data-tier-alloc-decider
Conversation
Clean this code up a little more as its one of the remaining rather expensive allocation deciders in profiling: * Make static what can be made static * extract cold paths to maybe make this compile a little better * Use the same logic in `tierNodesPresent` and `allocationAllowed` to have the `DATA_ROLE` shortcut in both.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
reviewed
Feb 7, 2022
| return allocation.decision( | ||
| Decision.NO, | ||
| NAME, | ||
| "index has a preference for tiers [%s], " + "but no nodes for any of those tiers are available in the cluster", |
Contributor
There was a problem hiding this comment.
NIT: unnecessary concatenation
idegtiarenko
reviewed
Feb 7, 2022
| return allocation.decision( | ||
| Decision.NO, | ||
| NAME, | ||
| "index has a preference for tiers [%s], " + "but no nodes for any of those tiers are available in the cluster", |
Contributor
There was a problem hiding this comment.
Suggested change
| "index has a preference for tiers [%s], " + "but no nodes for any of those tiers are available in the cluster", | |
| "index has a preference for tiers [%s], but no nodes for any of those tiers are available in the cluster", |
idegtiarenko
approved these changes
Feb 7, 2022
Contributor
Author
|
Thanks Ievgen! |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 7, 2022
* upstream/master: [DOCS] Switch xrefs to external links (elastic#83590) [DOCS] 'features' flag added in elastic#83083 (elastic#83452) Rename ChangePolicyforIndexIT to ChangePolicyForIndexIT (elastic#83569) Fixing random_sampler tests (elastic#83549) Upgrade Checkstyle to 9.3 (elastic#83314) Make improvements to the release notes generator (elastic#83525) Cleanup DataTierAllocationDecider (elastic#83572) Upgrade jANSI dependency to 2.4.0 (elastic#83566) Speed up Name Collision Check in Metadata.Builder (elastic#83340) SQL: Add range checks to interval multiplication operation (elastic#83478) Remove DiscoveryNodes#getAllNodes (elastic#83538) Make RoutingNodes behave like a collection (elastic#83540) Remove Unused CS Listener from SecurityServerTransportInterceptor (elastic#83556)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean this code up a little more as its one of the remaining rather expensive
allocation deciders in profiling:
tierNodesPresentandallocationAllowedto have theDATA_ROLEshortcut in both paths.