Add scaled float to the scripting fields API#82275
Merged
jdconrad merged 4 commits intoelastic:masterfrom Jan 5, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @jdconrad, I've created a changelog YAML for you. |
49 tasks
stu-elastic
reviewed
Jan 5, 2022
...ang-painless/src/yamlRestTest/resources/rest-api-spec/test/painless/50_script_doc_values.yml
Show resolved
Hide resolved
stu-elastic
approved these changes
Jan 5, 2022
Contributor
stu-elastic
left a comment
There was a problem hiding this comment.
Can you add unit tests to FloatDocValuesFieldTests? Looking good otherwise.
Contributor
Author
|
@stu-elastic Thanks for the review. I added unit tests as requested. Will commit as soon as CI passes. |
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
This adds the mapped type scaled float the scripting fields API using double as the base type.
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
This adds the mapped type scaled float the scripting fields API using double as the base type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the mapped type scaled float the scripting fields API using double as the base type.