Batch auto create index cluster state updates#82159
Merged
elasticsearchmachine merged 4 commits intoelastic:masterfrom Jan 11, 2022
Merged
Batch auto create index cluster state updates#82159elasticsearchmachine merged 4 commits intoelastic:masterfrom
elasticsearchmachine merged 4 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
original-brownbear
approved these changes
Jan 11, 2022
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM (but lets add a TODO as requested to make this nicer). For now this is a very nice speedup for our benchmarking.
server/src/main/java/org/elasticsearch/action/admin/indices/create/AutoCreateAction.java
Show resolved
Hide resolved
Contributor
|
@probakowski let's only do 8.1 here IMO. No need to push this to |
Contributor
Author
|
Thanks @original-brownbear! That makes sense, I'll do master only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds batching for cluster state updates to auto create index action. It will do a single reroute at the end of the batch which speeds up the operation