Remove NIO Transport Plugin#82085
Merged
original-brownbear merged 15 commits intoelastic:masterfrom Apr 12, 2022
original-brownbear:netty-all-the-way
Merged
Remove NIO Transport Plugin#82085original-brownbear merged 15 commits intoelastic:masterfrom original-brownbear:netty-all-the-way
original-brownbear merged 15 commits intoelastic:masterfrom
original-brownbear:netty-all-the-way
Conversation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
Thanks Armin, just one question.
| testImplementation project(path: xpackModule('ilm')) | ||
|
|
||
| testImplementation "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}" | ||
| testImplementation project(':plugins:transport-nio') // for http |
Contributor
There was a problem hiding this comment.
Am I right in thinking that this is a left-over from #82088? Or was there never a need for this?
Contributor
Author
There was a problem hiding this comment.
I don't think this was ever needed. The one test actually using HTTP org.elasticsearch.xpack.autoscaling.action.GetAutoscalingCapacityRestCancellationIT was always using Netty as far as I can tell from the git history. The same is true for other x-pack plugin build.gradle adjusted here.
Contributor
Author
|
npnp :) thanks for taking a look! |
Contributor
Author
|
🎉 thanks Henning! |
Contributor
|
I feel like this should be documented in the release notes, potentially as a breaking change. We have been publishing this plugin for folks to potentially use. Might be worth some acknowledgement that it's no longer available. |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Apr 13, 2022
* upstream/master: (40 commits) Fix BuildTests serialization (elastic#85827) Use urgent priority for node shutdown cluster state update (elastic#85838) Remove Task classes from HLRC (elastic#85835) Remove unused migration classes (elastic#85834) Remove uses of Charset name parsing (elastic#85795) Remove legacy versioned logic for DefaultSystemMemoryInfo (elastic#85761) Expose proxy settings for GCS repositories (elastic#85785) Remove SLM classes from HLRC (elastic#85825) TSDB: fix the time_series in order collect priority (elastic#85526) Remove ILM classes from HLRC (elastic#85822) FastVectorHighlighter should use ValueFetchers to load source data (elastic#85815) Iteratively execute synchronous ingest processors (elastic#84250) Remove TransformClient from HLRC (elastic#85787) Mute XPackRestIT deprecation/10_basic/Test Deprecations (elastic#85807) Unmute Lintian packaging test (elastic#85778) Add a highlighter unit test base class (elastic#85719) Remove NIO Transport Plugin (elastic#82085) [TEST] Remove token methods from HLRC SecurityClient (elastic#85515) [Test] Use thread-safe hashSet for result collection (elastic#85653) [TEST] Mute BuildTests.testSerialization (elastic#85801) ... # Conflicts: # server/src/test/java/org/elasticsearch/search/aggregations/timeseries/TimeSeriesIndexSearcherTests.java
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
transport-nioplugin completely.