Skip to content

[DOCS] Archived settings block other setting updates#82069

Merged
jrodewig merged 3 commits intoelastic:masterfrom
jrodewig:docs__fix-archived-settings
Jan 26, 2022
Merged

[DOCS] Archived settings block other setting updates#82069
jrodewig merged 3 commits intoelastic:masterfrom
jrodewig:docs__fix-archived-settings

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Dec 23, 2021

Changes:

  • Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings.
  • Notes that archived index settings can block index settings updates. For example, it blocks index.hidden but not number_of_replicas. Previously, the docs stated that you could safely ignore archived index settings.

Preview

https://elasticsearch_82069.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/archived-settings.html

Relates #78351

Closes #61175

@jrodewig jrodewig added >docs General docs changes :Core/Infra/Settings Settings infrastructure and APIs v8.1.0 v8.0.0-beta1 v7.15.3 v7.16.3 labels Dec 23, 2021
@jrodewig jrodewig requested a review from DaveCTurner December 23, 2021 16:22
@jrodewig jrodewig marked this pull request as ready for review December 23, 2021 16:22
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Core/Infra Meta label for core/infra team labels Dec 23, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Copy Markdown

@j-bennet j-bennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 I really hope the inconsistent behavior can be fixed in the future though, besides only being clarified in the documentation.

Removing archived index settings requires a reindex after the upgrade. However,
reindexing can be resource intensive. Because {es} ignores archived settings,
you can safely leave them in place if wanted.
Removing an index's archived index settings requires a <<docs-reindex,reindex>>.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clarification is great.

@bpintea bpintea added v7.16.4 and removed v7.16.3 labels Jan 10, 2022
@jrodewig
Copy link
Copy Markdown
Contributor Author

@DaveCTurner @gwbrown Do one of you mind taking a look at this PR at your convenience? Thank you!

@jrodewig
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@jrodewig
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

Copy link
Copy Markdown
Contributor

@AthenaEryma AthenaEryma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! And again, apologies for the delay!

@jrodewig
Copy link
Copy Markdown
Contributor Author

Thanks @gwbrown!

@jrodewig jrodewig merged commit 47d45d0 into elastic:master Jan 26, 2022
@jrodewig jrodewig deleted the docs__fix-archived-settings branch January 26, 2022 17:21
@jrodewig
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.0
7.17
7.16

Questions ?

Please refer to the Backport tool documentation

@jrodewig
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
7.15

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Jan 26, 2022
**Changes:**

* Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings.
* Notes that archived index settings can block index settings updates. For example, it blocks `index.hidden` but not `number_of_replicas`. Previously, the docs stated that you could safely ignore archived index settings.

Relates #78351

Closes #61175

(cherry picked from commit 47d45d0)
elasticsearchmachine pushed a commit that referenced this pull request Jan 26, 2022
**Changes:**

* Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings.
* Notes that archived index settings can block index settings updates. For example, it blocks `index.hidden` but not `number_of_replicas`. Previously, the docs stated that you could safely ignore archived index settings.

Relates #78351

Closes #61175

(cherry picked from commit 47d45d0)
elasticsearchmachine pushed a commit that referenced this pull request Jan 26, 2022
**Changes:**

* Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings.
* Notes that archived index settings can block index settings updates. For example, it blocks `index.hidden` but not `number_of_replicas`. Previously, the docs stated that you could safely ignore archived index settings.

Relates #78351

Closes #61175

(cherry picked from commit 47d45d0)
elasticsearchmachine pushed a commit that referenced this pull request Jan 26, 2022
**Changes:**

* Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings.
* Notes that archived index settings can block index settings updates. For example, it blocks `index.hidden` but not `number_of_replicas`. Previously, the docs stated that you could safely ignore archived index settings.

Relates #78351

Closes #61175

(cherry picked from commit 47d45d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Settings Settings infrastructure and APIs >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.15.3 v7.16.4 v7.17.0 v8.0.0 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PUT /_cluster/settings/" while throw IllegalArgumentException

6 participants