Skip to content

[ML] Expected snapshot min version is now 8#81054

Merged
droberts195 merged 4 commits intoelastic:masterfrom
droberts195:fix_expected_snapshot_version
Nov 25, 2021
Merged

[ML] Expected snapshot min version is now 8#81054
droberts195 merged 4 commits intoelastic:masterfrom
droberts195:fix_expected_snapshot_version

Conversation

@droberts195
Copy link
Copy Markdown

@droberts195 droberts195 commented Nov 25, 2021 •
edited
Loading

Followup to elastic/ml-cpp#2139

Fixes #81055
Fixes #81070

@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Nov 25, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Nov 25, 2021

Pinging @elastic/ml-core (Team:ML)

@droberts195 droberts195 mentioned this pull request Nov 25, 2021
Closed
@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Nov 25, 2021

Jenkins run elasticsearch-ci/eql-correctness

1 similar comment
@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Nov 25, 2021

Jenkins run elasticsearch-ci/eql-correctness

dimitris-athanasiou
dimitris-athanasiou approved these changes Nov 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx tlrx mentioned this pull request Nov 25, 2021
Merged
@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Nov 25, 2021

Jenkins run elasticsearch-ci/eql-correctness

@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Nov 25, 2021

Jenkins run elasticsearch-ci/part-1

@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Nov 25, 2021

Jenkins run elasticsearch-ci/bwc

@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Nov 25, 2021

Jenkins run elasticsearch-ci/bwc

@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Nov 25, 2021

The final failure of elasticsearch-ci/bwc was just an SSL glitch:

19:41:20 BUILD SUCCESSFUL in 54m 19s
19:41:20 681 actionable tasks: 557 executed, 124 from cache
19:41:20 
19:41:20 Publishing build scan...
19:41:20 https://gradle-enterprise.elastic.co/s/yjw5gwwyxvfjk

followed by:

19:41:45 [PostBuildScript] - [INFO] Executing post build scripts.
19:41:46 HttpMethod: GET
19:41:47 URL: https://homer.app.elstc.co/webhook/jenkins/build-finished
19:41:47 X-Jenkins-Build: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request+bwc/1779/
19:41:47 Sending request to url: https://homer.app.elstc.co/webhook/jenkins/build-finished
19:41:49 ERROR: Build step failed with exception
19:41:50 javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure

This sort of thing has been happening all day and since this PR is important I'm just going to merge it.

@droberts195 droberts195 merged commit d516785 into elastic:master Nov 25, 2021
@droberts195 droberts195 deleted the fix_expected_snapshot_version branch November 25, 2021 19:48
@droberts195 droberts195 mentioned this pull request Nov 25, 2021
Merged
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Nov 25, 2021

💚 Backport successful

Status Branch Result
✅ 8.0

droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Nov 25, 2021
@droberts195
[ML] Expected snapshot min version can now be 8 (elastic#81054)
27aba49 
Followup to elastic/ml-cpp#2139

Fixes elastic#81055
Fixes elastic#81070
droberts195 added a commit that referenced this pull request Nov 25, 2021
@droberts195
[ML] Expected snapshot min version can now be 8 (#81054) (#81071)
d7dd081 
Followup to elastic/ml-cpp#2139

Fixes #81055
Fixes #81070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees

No one assigned

Labels

:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.0.0 v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] MlJobSnapshotUpgradeIT testSnapshotUpgrader failing [CI] MlJobSnapshotUpgradeIT testSnapshotUpgrader failing

4 participants

@droberts195 @elasticmachine @elasticsearchmachine @dimitris-athanasiou