[Transform] Remove legacy transform templates#80948
Merged
droberts195 merged 3 commits intoelastic:masterfrom Nov 24, 2021
Merged
[Transform] Remove legacy transform templates#80948droberts195 merged 3 commits intoelastic:masterfrom
droberts195 merged 3 commits intoelastic:masterfrom
Conversation
Legacy transform templates will exist in clusters where transforms were first used prior to 7.16.0. (From 7.16.0 transforms uses composable templates.) Unlike ML, there's no danger these legacy templates date back to 6.x and contain types, so they are not at risk of being broken in 8.x. But it's still good to remove them from the cluster to keep it as clean as possible.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
approved these changes
Nov 24, 2021
...full-cluster-restart/src/test/java/org/elasticsearch/xpack/restart/FullClusterRestartIT.java
Show resolved
Hide resolved
hendrikmuhs
approved these changes
Nov 24, 2021
hendrikmuhs
left a comment
There was a problem hiding this comment.
LGTM
An alternative would be to do this as part of the _upgrade endpoint (TransportUpgradeTransformsAction) next to the deletion of old indices. But as this is not re-occurring, it is simpler and sufficient to do this here.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Nov 24, 2021
Legacy transform templates will exist in clusters where transforms were first used prior to 7.16.0. (From 7.16.0 transforms uses composable templates.) Unlike ML, there's no danger these legacy templates date back to 6.x and contain types, so they are not at risk of being broken in 8.x. But it's still good to remove them from the cluster to keep it as clean as possible.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 24, 2021
Legacy transform templates will exist in clusters where transforms were first used prior to 7.16.0. (From 7.16.0 transforms uses composable templates.) Unlike ML, there's no danger these legacy templates date back to 6.x and contain types, so they are not at risk of being broken in 8.x. But it's still good to remove them from the cluster to keep it as clean as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy transform templates will exist in clusters where
transforms were first used prior to 7.16.0. (From 7.16.0
transforms uses composable templates.)
Unlike ML, there's no danger these legacy templates date
back to 6.x and contain types, so they are not at risk of
being broken in 8.x. But it's still good to remove them
from the cluster to keep it as clean as possible.