Document the declarative plugins configuration file#80760
Merged
pugnascotia merged 4 commits intoelastic:masterfrom Nov 17, 2021
Merged
Document the declarative plugins configuration file#80760pugnascotia merged 4 commits intoelastic:masterfrom
pugnascotia merged 4 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
approved these changes
Nov 16, 2021
Contributor
mark-vieira
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM.
jrodewig
approved these changes
Nov 17, 2021
Contributor
jrodewig
left a comment
There was a problem hiding this comment.
LGTM aside from some minor formatting fixes. The rest of my feedback consists of wording nits. Feel free to disregard those if wanted.
|
|
||
| [IMPORTANT] | ||
| . Docker only | ||
| ===================== |
Contributor
There was a problem hiding this comment.
Not a big deal, but we only require four delimiters. No real reason to use more. For example:
[IMPORTANT]
.Docker only
====
My admon text
====
Contributor
Author
There was a problem hiding this comment.
I was copying from other lines in the file. I'll remember that for the future.
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Contributor
Author
|
Thanks @jrodewig! |
pugnascotia
added a commit
that referenced
this pull request
Nov 17, 2021
pugnascotia
added a commit
that referenced
this pull request
Nov 17, 2021
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #77544.