Remove unused fields in ActionTransportException#80692
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom Nov 15, 2021
Merged
Conversation
The fields in `ActionTransportException` are reflected in the message generated at construction time, and apart from that they are only used in tests. This commit removes them, and hence another spot where we were creating a per-message `TransportAddress` object. Relates elastic#80690
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 23, 2021
Today we use `writeBoolean(false);` to write to a `StreamOutput` an optional value that is always missing. It's something of an implementation detail that a missing value is indicated by a `false` (i.e. a zero byte) so this commit wraps these calls in methods that better indicate the intent. Relates elastic#80944 Relates elastic#80692
DaveCTurner
added a commit
that referenced
this pull request
Nov 23, 2021
Today we use `writeBoolean(false);` to write to a `StreamOutput` an optional value that is always missing. It's something of an implementation detail that a missing value is indicated by a `false` (i.e. a zero byte) so this commit wraps these calls in methods that better indicate the intent. Relates #80944 Relates #80692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fields in
ActionTransportExceptionare reflected in the messagegenerated at construction time, and apart from that they are only used
in tests. This commit removes them, and hence another spot where we were
creating a per-message
TransportAddressobject.Relates #80690