[ML] Fix mocking failure in MlDailyMaintenanceServiceTests#80657
Merged
davidkyle merged 1 commit intoelastic:masterfrom Nov 11, 2021
Merged
[ML] Fix mocking failure in MlDailyMaintenanceServiceTests#80657davidkyle merged 1 commit intoelastic:masterfrom
davidkyle merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
approved these changes
Nov 11, 2021
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 11, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First fixed in #80000 now a different failure with
verifyNoMoreInteractionsoccurs very rarely. This verification is not important, the preceding ones check the behaviour. The Mockito docs offer this advice onverifyNoMoreInteractionswhich I've taken to heart:Closes #79971